Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 1973863003: Implement SetWrapperReferenceFrom idl attribute within traceWrappers for media tracks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary tracing Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 3604 matching lines...) Expand 10 before | Expand all | Expand 10 after
3615 visitor->trace(m_audioSourceProvider); 3615 visitor->trace(m_audioSourceProvider);
3616 visitor->trace(m_autoplayHelperClient); 3616 visitor->trace(m_autoplayHelperClient);
3617 visitor->trace(m_autoplayHelper); 3617 visitor->trace(m_autoplayHelper);
3618 visitor->trace(m_srcObject); 3618 visitor->trace(m_srcObject);
3619 visitor->template registerWeakMembers<HTMLMediaElement, &HTMLMediaElement::c learWeakMembers>(this); 3619 visitor->template registerWeakMembers<HTMLMediaElement, &HTMLMediaElement::c learWeakMembers>(this);
3620 Supplementable<HTMLMediaElement>::trace(visitor); 3620 Supplementable<HTMLMediaElement>::trace(visitor);
3621 HTMLElement::trace(visitor); 3621 HTMLElement::trace(visitor);
3622 ActiveDOMObject::trace(visitor); 3622 ActiveDOMObject::trace(visitor);
3623 } 3623 }
3624 3624
3625 DEFINE_TRACE_WRAPPERS(HTMLMediaElement)
3626 {
3627 visitor->traceWrappers(m_videoTracks);
3628 visitor->traceWrappers(m_audioTracks);
3629 visitor->traceWrappers(m_textTracks);
3630 HTMLElement::traceWrappers(visitor);
3631 }
3632
3625 void HTMLMediaElement::createPlaceholderTracksIfNecessary() 3633 void HTMLMediaElement::createPlaceholderTracksIfNecessary()
3626 { 3634 {
3627 if (!RuntimeEnabledFeatures::audioVideoTracksEnabled()) 3635 if (!RuntimeEnabledFeatures::audioVideoTracksEnabled())
3628 return; 3636 return;
3629 3637
3630 // Create a placeholder audio track if the player says it has audio but it d idn't explicitly announce the tracks. 3638 // Create a placeholder audio track if the player says it has audio but it d idn't explicitly announce the tracks.
3631 if (hasAudio() && !audioTracks().length()) 3639 if (hasAudio() && !audioTracks().length())
3632 addAudioTrack("audio", WebMediaPlayerClient::AudioTrackKindMain, "Audio Track", "", true); 3640 addAudioTrack("audio", WebMediaPlayerClient::AudioTrackKindMain, "Audio Track", "", true);
3633 3641
3634 // Create a placeholder video track if the player says it has video but it d idn't explicitly announce the tracks. 3642 // Create a placeholder video track if the player says it has video but it d idn't explicitly announce the tracks.
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
3865 3873
3866 IntRect HTMLMediaElement::AutoplayHelperClientImpl::absoluteBoundingBoxRect() co nst 3874 IntRect HTMLMediaElement::AutoplayHelperClientImpl::absoluteBoundingBoxRect() co nst
3867 { 3875 {
3868 IntRect result; 3876 IntRect result;
3869 if (LayoutObject* object = m_element->layoutObject()) 3877 if (LayoutObject* object = m_element->layoutObject())
3870 result = object->absoluteBoundingBoxRect(); 3878 result = object->absoluteBoundingBoxRect();
3871 return result; 3879 return result;
3872 } 3880 }
3873 3881
3874 } // namespace blink 3882 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.h ('k') | third_party/WebKit/Source/core/html/track/TextTrack.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698