third_party/WebKit/Source/core/html/track/TextTrack.cpp - Issue 1973863003: Implement SetWrapperReferenceFrom idl attribute within traceWrappers for media tracks

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/html/track/TextTrack.cpp

Issue 1973863003: Implement SetWrapperReferenceFrom idl attribute within traceWrappers for media tracks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Google Inc. All rights reserved.	2 * Copyright (C) 2011 Google Inc. All rights reserved.

3 * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved.	3 * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions are	6 * modification, are permitted provided that the following conditions are

7 * met:	7 * met:

8 *	8 *

9 * * Redistributions of source code must retain the above copyright	9 * * Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 473 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
484 DEFINE_TRACE(TextTrack)	484 DEFINE_TRACE(TextTrack)

485 {	485 {

486 visitor->trace(m_cues);	486 visitor->trace(m_cues);

487 visitor->trace(m_activeCues);	487 visitor->trace(m_activeCues);

488 visitor->trace(m_regions);	488 visitor->trace(m_regions);

489 visitor->trace(m_trackList);	489 visitor->trace(m_trackList);

490 TrackBase::trace(visitor);	490 TrackBase::trace(visitor);

491 EventTargetWithInlineData::trace(visitor);	491 EventTargetWithInlineData::trace(visitor);

492 }	492 }

493	493

	494 DEFINE_TRACE_WRAPPERS(TextTrack)

	495 {

	496 visitor->traceWrappers(m_cues);

	497 EventTargetWithInlineData::traceWrappers(visitor);
	haraken 2016/05/12 16:02:54 I don't think we need to trace this. EventTargetWi I don't think we need to trace this. EventTargetWithInlineData::traceWrappers needs to be traced only if the object inherits from Node. Non-Node objects won't need to call the traceWrappers(). See https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit... The same comment for other EventTargetWithInlineData::traceWrappers in this CL. Marcel Hlopko 2016/05/12 16:15:51 You are correct. Removing. There really isn't that You are correct. Removing. There really isn't that much to trace :)
	498 }

494 } // namespace blink	499 } // namespace blink

OLD	NEW