Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1973843003: LayoutBox (not LayoutBlock) is the common base for floats and out-of-flow objects. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
eae, szager1, wkorman
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutBox (not LayoutBlock) is the common base for floats and out-of-flow objects. We need to react on going out-of-flow or becoming floated in LayoutBox::styleDidChange(), or we'll misbehave if the object in question is e.g. an image. Committed: https://crrev.com/49ac8d40f0a2d24f85a7e5483045474e8d8eb617 Cr-Commit-Position: refs/heads/master@{#393270}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/block/block-image-becomes-float.html View 1 chunk +12 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/block/block-image-becomes-float-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
Old bug. I searched the BTS, but came up empty.
4 years, 7 months ago (2016-05-12 12:41:25 UTC) #2
eae
OK, LGTM
4 years, 7 months ago (2016-05-12 16:26:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973843003/1
4 years, 7 months ago (2016-05-12 16:27:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 16:31:07 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 16:32:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49ac8d40f0a2d24f85a7e5483045474e8d8eb617
Cr-Commit-Position: refs/heads/master@{#393270}

Powered by Google App Engine
This is Rietveld 408576698