Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 1973843002: Set hard_dependency for media and media_features gyp targets (Closed)

Created:
4 years, 7 months ago by tapted
Modified:
4 years, 7 months ago
Reviewers:
brettw, servolk
CC:
chromium-reviews, feature-media-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set hard_dependency for media and media_features gyp targets The media_features gyp target generates a header that is included by many other files indirectly through media/base/video_codecs.h, so both the main media target and media_features target must be marked as hard_dependency: 1, to ensure the media_features.h header is generated before being used anywhere. patch originally from http://crrev.com/1969493002#ps20001 Added export_dependent_settings += [ media_features ]. +TBR to fix waterfall breakage. BUG=606829 TBR=servolk@chromium.org,brettw@chromium.org Committed: https://crrev.com/2c872f31329bb434f00b5cba3e61664ec3970ddc Cr-Commit-Position: refs/heads/master@{#393187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M media/media.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tapted
4 years, 7 months ago (2016-05-12 04:53:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973843002/1
4 years, 7 months ago (2016-05-12 04:53:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 04:59:42 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 05:00:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c872f31329bb434f00b5cba3e61664ec3970ddc
Cr-Commit-Position: refs/heads/master@{#393187}

Powered by Google App Engine
This is Rietveld 408576698