Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Side by Side Diff: chrome/browser/ui/webui/options/options_browsertest.js

Issue 1973823002: Disable failing accessibility audit in OptionsWebUITest tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update bugref Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 GEN_INCLUDE(['options_browsertest_base.js']); 5 GEN_INCLUDE(['options_browsertest_base.js']);
6 GEN('#include "chrome/browser/ui/webui/options/options_browsertest.h"'); 6 GEN('#include "chrome/browser/ui/webui/options/options_browsertest.h"');
7 7
8 /** @const */ var SUPERVISED_USERS_PREF = 'profile.managed_users'; 8 /** @const */ var SUPERVISED_USERS_PREF = 'profile.managed_users';
9 9
10 /** 10 /**
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 '#languages-section > .settings-row > A', 96 '#languages-section > .settings-row > A',
97 '#cloudprint-options-mdns > .settings-row > A', 97 '#cloudprint-options-mdns > .settings-row > A',
98 '#do-not-track-confirm-overlay > .action-area > .hbox.stretch > A', 98 '#do-not-track-confirm-overlay > .action-area > .hbox.stretch > A',
99 ]; 99 ];
100 100
101 // Enable when failure is resolved. 101 // Enable when failure is resolved.
102 // AX_TEXT_04: http://crbug.com/559318 102 // AX_TEXT_04: http://crbug.com/559318
103 this.accessibilityAuditConfig.ignoreSelectors( 103 this.accessibilityAuditConfig.ignoreSelectors(
104 'linkWithUnclearPurpose', 104 'linkWithUnclearPurpose',
105 linkWithUnclearPurposeSelectors); 105 linkWithUnclearPurposeSelectors);
106
107 // Causes testDefaultZoomFactor to flake. See http://crbug.com/611233.
108 var requiredOwnedAriaRoleMissingSelectors = [
109 '#default-search-engine-list',
110 '#other-search-engine-list',
111 ];
112
113 // Enable when failure is resolved.
114 // AX_ARIA_08: http://crbug.com/606657
115 this.accessibilityAuditConfig.ignoreSelectors(
116 'requiredOwnedAriaRoleMissing',
117 requiredOwnedAriaRoleMissingSelectors);
106 }, 118 },
107 }; 119 };
108 120
109 /** 121 /**
110 * Wait for all targets to be hidden. 122 * Wait for all targets to be hidden.
111 * @param {Array<Element>} targets 123 * @param {Array<Element>} targets
112 */ 124 */
113 function waitUntilHidden(targets) { 125 function waitUntilHidden(targets) {
114 function isHidden(el) { return el.hidden; } 126 function isHidden(el) { return el.hidden; }
115 function ensureTransition(el) { ensureTransitionEndEvent(el, 500); } 127 function ensureTransition(el) { ensureTransitionEndEvent(el, 500); }
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 window.location.reload(); 175 window.location.reload();
164 176
165 assertEquals('chrome://settings-frame/searchEngines', document.location.href); 177 assertEquals('chrome://settings-frame/searchEngines', document.location.href);
166 assertFalse($('search-engine-manager-page').hidden); 178 assertFalse($('search-engine-manager-page').hidden);
167 testDone(); 179 testDone();
168 }); 180 });
169 181
170 /** 182 /**
171 * Test the default zoom factor select element. 183 * Test the default zoom factor select element.
172 */ 184 */
173 TEST_F('OptionsWebUITest', 'testDefaultZoomFactor', function() { 185 TEST_F('OptionsWebUITest', 'MAYBE_testDefaultZoomFactor', function() {
michaelpg 2016/05/12 03:36:24 remove MAYBE_
tapted 2016/05/12 03:41:00 Done. (whoops)
174 // The expected minimum length of the |defaultZoomFactor| element. 186 // The expected minimum length of the |defaultZoomFactor| element.
175 var defaultZoomFactorMinimumLength = 10; 187 var defaultZoomFactorMinimumLength = 10;
176 // Verify that the zoom factor element exists. 188 // Verify that the zoom factor element exists.
177 var defaultZoomFactor = $('defaultZoomFactor'); 189 var defaultZoomFactor = $('defaultZoomFactor');
178 assertNotEquals(defaultZoomFactor, null); 190 assertNotEquals(defaultZoomFactor, null);
179 191
180 // Verify that the zoom factor element has a reasonable number of choices. 192 // Verify that the zoom factor element has a reasonable number of choices.
181 expectGE(defaultZoomFactor.options.length, defaultZoomFactorMinimumLength); 193 expectGE(defaultZoomFactor.options.length, defaultZoomFactorMinimumLength);
182 194
183 // Simulate a change event, selecting the highest zoom value. Verify that 195 // Simulate a change event, selecting the highest zoom value. Verify that
(...skipping 762 matching lines...) Expand 10 before | Expand all | Expand 10 after
946 __proto__: OptionsWebUIExtendedTest.prototype, 958 __proto__: OptionsWebUIExtendedTest.prototype,
947 959
948 /** @override */ 960 /** @override */
949 browsePreload: 'chrome://settings-frame/nonexistantPage', 961 browsePreload: 'chrome://settings-frame/nonexistantPage',
950 }; 962 };
951 963
952 TEST_F('OptionsWebUIRedirectTest', 'TestURL', function() { 964 TEST_F('OptionsWebUIRedirectTest', 'TestURL', function() {
953 assertEquals('chrome://settings-frame/', document.location.href); 965 assertEquals('chrome://settings-frame/', document.location.href);
954 this.verifyHistory_([''], testDone); 966 this.verifyHistory_([''], testDone);
955 }); 967 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698