Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1973823002:
Disable failing accessibility audit in OptionsWebUITest tests. (Closed)
|
Created:
4 years, 7 months ago by tapted Modified:
4 years, 7 months ago CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, chrome-apps-syd-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable failing accessibility audit in OptionsWebUITest tests.
Causes OptionsWebUITest.testDefaultZoomFactor to flake.
TBR=dbeam@chromium.org
BUG=611233, 606657
Committed: https://crrev.com/b04fffc834429a96ddc89a32113b429aa52025b0
Cr-Commit-Position: refs/heads/master@{#393181}
Patch Set 1 #Patch Set 2 : disable requiredOwnedAriaRoleMissing #Patch Set 3 : update bugref #
Total comments: 2
Patch Set 4 : remove MAYBE_ #Messages
Total messages: 19 (10 generated)
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973823002/1
looks like a dupe of 606657, could we try just ignoring the troublesome a11y warning instead of disabling the whole test? see also: https://codereview.chromium.org/1910953004
The CQ bit was unchecked by tapted@chromium.org
Description was changed from ========== Disable Flaky OptionsWebUITest.testDefaultZoomFactor on Win TBR=michaelpg@chromium.org BUG=611233 ========== to ========== Disable failing accessibility audit in OptionsWebUITest tests. Causes OptionsWebUITest.testDefaultZoomFactor to flake. The unresolved error is currently disabled and a crbug filed. TBR=michaelpg@chromium.org BUG=611233, 606657 ==========
Description was changed from ========== Disable failing accessibility audit in OptionsWebUITest tests. Causes OptionsWebUITest.testDefaultZoomFactor to flake. The unresolved error is currently disabled and a crbug filed. TBR=michaelpg@chromium.org BUG=611233, 606657 ========== to ========== Disable failing accessibility audit in OptionsWebUITest tests. Causes OptionsWebUITest.testDefaultZoomFactor to flake. TBR=michaelpg@chromium.org BUG=611233, 606657 ==========
On 2016/05/12 02:51:05, michaelpg wrote: > looks like a dupe of 606657, could we try just ignoring the troublesome a11y > warning instead of disabling the whole test? > > see also: https://codereview.chromium.org/1910953004 Done.
thanks, lgtm https://codereview.chromium.org/1973823002/diff/40001/chrome/browser/ui/webui... File chrome/browser/ui/webui/options/options_browsertest.js (right): https://codereview.chromium.org/1973823002/diff/40001/chrome/browser/ui/webui... chrome/browser/ui/webui/options/options_browsertest.js:185: TEST_F('OptionsWebUITest', 'MAYBE_testDefaultZoomFactor', function() { remove MAYBE_
Description was changed from ========== Disable failing accessibility audit in OptionsWebUITest tests. Causes OptionsWebUITest.testDefaultZoomFactor to flake. TBR=michaelpg@chromium.org BUG=611233, 606657 ========== to ========== Disable failing accessibility audit in OptionsWebUITest tests. Causes OptionsWebUITest.testDefaultZoomFactor to flake. TBR=dbeam@chromium.org BUG=611233, 606657 ==========
tapted@chromium.org changed reviewers: + dbeam@chromium.org
(+dbeam TBR for owners) https://codereview.chromium.org/1973823002/diff/40001/chrome/browser/ui/webui... File chrome/browser/ui/webui/options/options_browsertest.js (right): https://codereview.chromium.org/1973823002/diff/40001/chrome/browser/ui/webui... chrome/browser/ui/webui/options/options_browsertest.js:185: TEST_F('OptionsWebUITest', 'MAYBE_testDefaultZoomFactor', function() { On 2016/05/12 03:36:24, michaelpg wrote: > remove MAYBE_ Done. (whoops)
The CQ bit was checked by tapted@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from michaelpg@chromium.org Link to the patchset: https://codereview.chromium.org/1973823002/#ps60001 (title: "remove MAYBE_")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973823002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973823002/60001
Message was sent while issue was closed.
Description was changed from ========== Disable failing accessibility audit in OptionsWebUITest tests. Causes OptionsWebUITest.testDefaultZoomFactor to flake. TBR=dbeam@chromium.org BUG=611233, 606657 ========== to ========== Disable failing accessibility audit in OptionsWebUITest tests. Causes OptionsWebUITest.testDefaultZoomFactor to flake. TBR=dbeam@chromium.org BUG=611233, 606657 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Disable failing accessibility audit in OptionsWebUITest tests. Causes OptionsWebUITest.testDefaultZoomFactor to flake. TBR=dbeam@chromium.org BUG=611233, 606657 ========== to ========== Disable failing accessibility audit in OptionsWebUITest tests. Causes OptionsWebUITest.testDefaultZoomFactor to flake. TBR=dbeam@chromium.org BUG=611233, 606657 Committed: https://crrev.com/b04fffc834429a96ddc89a32113b429aa52025b0 Cr-Commit-Position: refs/heads/master@{#393181} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/b04fffc834429a96ddc89a32113b429aa52025b0 Cr-Commit-Position: refs/heads/master@{#393181} |
