Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1973743004: Make LoggingNetworkChangeObserver log specific network changes (Closed)

Created:
4 years, 7 months ago by pauljensen
Modified:
4 years, 7 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cronetlog
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make LoggingNetworkChangeObserver log specific network changes BUG=610293 Committed: https://crrev.com/c8450e9104c000efa1f7cb20d34e13bf08774b54 Cr-Commit-Position: refs/heads/master@{#395520}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : don't register if NetworkHandles not supported #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -18 lines) Patch
M net/base/logging_network_change_observer.h View 2 chunks +12 lines, -2 lines 0 comments Download
M net/base/logging_network_change_observer.cc View 1 2 3 4 5 6 1 chunk +83 lines, -16 lines 0 comments Download
M net/log/net_log_event_type_list.h View 1 2 3 4 5 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
pauljensen
Helen, PTAL.
4 years, 7 months ago (2016-05-23 14:34:11 UTC) #2
xunjieli
lgtm
4 years, 7 months ago (2016-05-23 20:21:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973743004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973743004/100001
4 years, 7 months ago (2016-05-23 21:23:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/115878)
4 years, 7 months ago (2016-05-23 21:56:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973743004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973743004/120001
4 years, 7 months ago (2016-05-24 01:14:45 UTC) #10
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 7 months ago (2016-05-24 02:49:33 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 02:51:41 UTC) #13
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/c8450e9104c000efa1f7cb20d34e13bf08774b54
Cr-Commit-Position: refs/heads/master@{#395520}

Powered by Google App Engine
This is Rietveld 408576698