Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1973743003: Fix use-afer-free in PrintContext. (Closed)

Created:
4 years, 7 months ago by chrishtr
Modified:
4 years, 7 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix use-afer-free in PrintContext. The LayoutBoxModelObject may have been deleted during a style recalc triggered by setPrinting(), which PrintContext::begin() calls. BUG=610979 Committed: https://crrev.com/fb04c5c901794b87adb71d361558439fb35f5d16 Cr-Commit-Position: refs/heads/master@{#393380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/Source/core/page/PrintContext.cpp View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
chrishtr
4 years, 7 months ago (2016-05-12 06:06:21 UTC) #3
Xianzhu
lgtm
4 years, 7 months ago (2016-05-12 22:37:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973743003/1
4 years, 7 months ago (2016-05-12 22:37:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 22:41:50 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 22:44:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb04c5c901794b87adb71d361558439fb35f5d16
Cr-Commit-Position: refs/heads/master@{#393380}

Powered by Google App Engine
This is Rietveld 408576698