Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5944)

Unified Diff: chrome/browser/resources/settings/about_page/about_page.js

Issue 1973733002: MD Settings: About page, setup for showing a sub-page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comment. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/about_page/about_page.js
diff --git a/chrome/browser/resources/settings/about_page/about_page.js b/chrome/browser/resources/settings/about_page/about_page.js
index 5cced4f7244bbf44fbb09e31de0d38cd79dc7ff1..4c7fb9c36172c6ef566011dd579639538a70d43e 100644
--- a/chrome/browser/resources/settings/about_page/about_page.js
+++ b/chrome/browser/resources/settings/about_page/about_page.js
@@ -8,4 +8,35 @@
*/
Polymer({
is: 'settings-about-page',
+
+ behaviors: [RoutableBehavior],
Dan Beam 2016/05/12 18:29:46 probably just need to add this as a compiled_resou
dpapad 2016/05/12 18:46:27 Added to compiled_resources2.gyp. The HTML import
+
+ properties: {
+ /**
+ * The current active route.
+ */
+ currentRoute: {
+ type: Object,
+ notify: true,
+ },
+ },
+
+ /**
+ * @type {string} Selector to get the sections.
+ * TODO(michaelpg): replace duplicate docs with @override once b/24294625
+ * is fixed.
+ */
+ sectionSelector: 'settings-section',
+
+ /** @override */
+ attached: function() {
+ this.scroller = this.parentElement;
+ },
+
+<if expr="chromeos">
+ /** @private */
+ onDetailedBuildInfoTap_: function() {
+ this.$.pages.setSubpageChain(['detailed-build-info']);
+ },
+</if>
});

Powered by Google App Engine
This is Rietveld 408576698