Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_router.js

Issue 1973733002: MD Settings: About page, setup for showing a sub-page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing Closure compilation. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @typedef {{ 6 * @typedef {{
7 * url: string, 7 * url: string,
8 * page: string, 8 * page: string,
9 * section: string, 9 * section: string,
10 * subpage: !Array<string>, 10 * subpage: !Array<string>,
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 page: 'basic', 94 page: 'basic',
95 section: '', 95 section: '',
96 subpage: [], 96 subpage: [],
97 }, 97 },
98 { 98 {
99 url: '/help', 99 url: '/help',
100 page: 'about', 100 page: 'about',
101 section: '', 101 section: '',
102 subpage: [], 102 subpage: [],
103 }, 103 },
104 <if expr="chromeos">
105 {
106 url: '/help/details',
107 page: 'about',
108 section: 'about',
109 subpage: ['detailed-build-info'],
110 },
111 </if>
104 { 112 {
105 url: '/advanced', 113 url: '/advanced',
106 page: 'advanced', 114 page: 'advanced',
107 section: '', 115 section: '',
108 subpage: [], 116 subpage: [],
109 }, 117 },
110 <if expr="chromeos"> 118 <if expr="chromeos">
111 { 119 {
112 url: '/internet', 120 url: '/internet',
113 page: 'basic', 121 page: 'basic',
(...skipping 425 matching lines...) Expand 10 before | Expand all | Expand 10 after
539 window.history.replaceState(historicState, document.title); 547 window.history.replaceState(historicState, document.title);
540 } 548 }
541 549
542 return; 550 return;
543 } 551 }
544 } 552 }
545 553
546 assertNotReached('Route not found: ' + JSON.stringify(newRoute)); 554 assertNotReached('Route not found: ' + JSON.stringify(newRoute));
547 }, 555 },
548 }); 556 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698