Implement //device/bt changes for notifications.

device/bluetooth/bluetooth_local_gatt_characteristic_unittest.cc

Index: device/bluetooth/bluetooth_local_gatt_characteristic_unittest.cc
diff --git a/device/bluetooth/bluetooth_local_gatt_characteristic_unittest.cc b/device/bluetooth/bluetooth_local_gatt_characteristic_unittest.cc
index dc9f9e8d99b6ccff0ae4765ac475c4c111a47c04..1978ccb45382bcf5dea06be5352c362de562f2dc 100644
--- a/device/bluetooth/bluetooth_local_gatt_characteristic_unittest.cc
+++ b/device/bluetooth/bluetooth_local_gatt_characteristic_unittest.cc
@@ -27,14 +27,27 @@ class BluetoothLocalGattCharacteristicTest : public BluetoothGattServerTest {
         device::BluetoothLocalGattCharacteristic::PROPERTY_RELIABLE_WRITE,
         device::BluetoothLocalGattCharacteristic::Permissions(),
         service_.get());
+    notify_characteristic_ = BluetoothLocalGattCharacteristic::Create(
+        BluetoothUUID(kTestUUIDGenericAttribute),
+        device::BluetoothLocalGattCharacteristic::PROPERTY_NOTIFY,
+        device::BluetoothLocalGattCharacteristic::Permissions(),
+        service_.get());
+    indicate_characteristic_ = BluetoothLocalGattCharacteristic::Create(
+        BluetoothUUID(kTestUUIDGenericAttribute),
+        device::BluetoothLocalGattCharacteristic::PROPERTY_INDICATE,
+        device::BluetoothLocalGattCharacteristic::Permissions(),
+        service_.get());
     EXPECT_LT(0u, read_characteristic_->GetIdentifier().size());
     EXPECT_LT(0u, write_characteristic_->GetIdentifier().size());
+    EXPECT_LT(0u, notify_characteristic_->GetIdentifier().size());
     CompleteGattSetup();
   }
 
  protected:
   base::WeakPtr<BluetoothLocalGattCharacteristic> read_characteristic_;
   base::WeakPtr<BluetoothLocalGattCharacteristic> write_characteristic_;
+  base::WeakPtr<BluetoothLocalGattCharacteristic> notify_characteristic_;
+  base::WeakPtr<BluetoothLocalGattCharacteristic> indicate_characteristic_;
 };
 
 #if defined(OS_CHROMEOS) || defined(OS_LINUX)
@@ -108,4 +121,87 @@ TEST_F(BluetoothLocalGattCharacteristicTest,
 }
 #endif  // defined(OS_CHROMEOS) || defined(OS_LINUX)
 
+#if defined(OS_CHROMEOS) || defined(OS_LINUX)
+TEST_F(BluetoothLocalGattCharacteristicTest, StartAndStopNotifications) {
+  EXPECT_FALSE(SimulateLocalGattCharacteristicNotificationsRequest(
+      service_.get(), read_characteristic_.get(), true));
+  EXPECT_FALSE(delegate_->NotificationStatusForCharacteristic(
+      read_characteristic_.get()));
+
+  EXPECT_FALSE(SimulateLocalGattCharacteristicNotificationsRequest(
+      service_.get(), write_characteristic_.get(), true));
+  EXPECT_FALSE(delegate_->NotificationStatusForCharacteristic(
+      write_characteristic_.get()));
+
+  EXPECT_TRUE(SimulateLocalGattCharacteristicNotificationsRequest(
+      service_.get(), notify_characteristic_.get(), true));
+  EXPECT_TRUE(delegate_->NotificationStatusForCharacteristic(
+      notify_characteristic_.get()));
+
+  EXPECT_TRUE(SimulateLocalGattCharacteristicNotificationsRequest(
+      service_.get(), notify_characteristic_.get(), false));
+  EXPECT_FALSE(delegate_->NotificationStatusForCharacteristic(
+      notify_characteristic_.get()));
+}
+#endif  // defined(OS_CHROMEOS) || defined(OS_LINUX)
+
+#if defined(OS_CHROMEOS) || defined(OS_LINUX)
+TEST_F(BluetoothLocalGattCharacteristicTest, SendNotifications) {
+  const uint64_t kNewValue = 0x3334ul;
+  EXPECT_EQ(
+      BluetoothLocalGattCharacteristic::NOTIFY_PROPERTY_NOT_SET,

[scheib, 2016/05/12 21:26:59]

I think these top two belong in SendNotificationsWrongProperties below.

[rkc, 2016/05/12 21:42:19]

Done.

+      read_characteristic_->NotifyValueChanged(GetValue(kNewValue), false));
+
+  EXPECT_EQ(
+      BluetoothLocalGattCharacteristic::NOTIFY_PROPERTY_NOT_SET,
+      write_characteristic_->NotifyValueChanged(GetValue(kNewValue), false));
+
+  const uint64_t kNotifyValue = 0x7331ul;
+  EXPECT_EQ(BluetoothLocalGattCharacteristic::NOTIFICATION_SUCCESS,
+            notify_characteristic_->NotifyValueChanged(GetValue(kNotifyValue),
+                                                       false));
+  EXPECT_EQ(kNotifyValue, GetInteger(LastNotifactionValueForCharacteristic(
+                              notify_characteristic_.get())));
+
+  const uint64_t kIndicateValue = 0x1337ul;
+  EXPECT_EQ(BluetoothLocalGattCharacteristic::NOTIFICATION_SUCCESS,
+            indicate_characteristic_->NotifyValueChanged(
+                GetValue(kIndicateValue), true));
+  EXPECT_EQ(kIndicateValue, GetInteger(LastNotifactionValueForCharacteristic(
+                                indicate_characteristic_.get())));
+}
+#endif  // defined(OS_CHROMEOS) || defined(OS_LINUX)
+
+#if defined(OS_CHROMEOS) || defined(OS_LINUX)
+TEST_F(BluetoothLocalGattCharacteristicTest, SendNotificationsWrongProperties) {
+  const uint64_t kNotifyValue = 0x7331ul;
+  EXPECT_EQ(
+      BluetoothLocalGattCharacteristic::INDICATE_PROPERTY_NOT_SET,
+      notify_characteristic_->NotifyValueChanged(GetValue(kNotifyValue), true));
+  EXPECT_NE(kNotifyValue, GetInteger(LastNotifactionValueForCharacteristic(
+                              notify_characteristic_.get())));
+
+  const uint64_t kIndicateValue = 0x1337ul;
+  EXPECT_EQ(BluetoothLocalGattCharacteristic::NOTIFY_PROPERTY_NOT_SET,
+            indicate_characteristic_->NotifyValueChanged(
+                GetValue(kIndicateValue), false));
+  EXPECT_NE(kIndicateValue, GetInteger(LastNotifactionValueForCharacteristic(
+                                indicate_characteristic_.get())));
+}
+#endif  // defined(OS_CHROMEOS) || defined(OS_LINUX)
+
+#if defined(OS_CHROMEOS) || defined(OS_LINUX)
+TEST_F(BluetoothLocalGattCharacteristicTest,
+       SendNotificationsServiceNotRegistered) {
+  service_->Unregister(GetCallback(Call::EXPECTED),
+                       GetGattErrorCallback(Call::NOT_EXPECTED));
+  const uint64_t kNotifyValue = 0x7331ul;
+  EXPECT_EQ(BluetoothLocalGattCharacteristic::SERVICE_NOT_REGISTERED,
+            notify_characteristic_->NotifyValueChanged(GetValue(kNotifyValue),
+                                                       false));
+  EXPECT_NE(kNotifyValue, GetInteger(LastNotifactionValueForCharacteristic(
+                              notify_characteristic_.get())));
+}
+#endif  // defined(OS_CHROMEOS) || defined(OS_LINUX)
+
 }  // namespace device