Add a new way of using ServiceProviderImpl without InterfaceFactory.

Add a new way of using ServiceProviderImpl without InterfaceFactory.

Instead, just take a factory function. This has a number of advantages:
* Classes don't have to implement InterfaceFactory<I> in order to
  "provide" services.
* Classes can (easily) instantiate impls in different ways (or
  instantiate different impls for the same service).

For now, the new method is called |AddServiceNew<I>()|, but I plan to
get rid of |AddService<I>()| and rename |AddServiceNew| to |AddService|.

Also, add a bunch of tests.

R=vardhan@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/65138ce8c234734966a4e299d8feba01d8c9ce07

[vardhan, 2016-05-11 23:09:35]

lgtm w/ nit

https://codereview.chromium.org/1973653002/diff/1/mojo/public/cpp/application...
File mojo/public/cpp/application/service_provider_impl.h (right):

https://codereview.chromium.org/1973653002/diff/1/mojo/public/cpp/application...
mojo/public/cpp/application/service_provider_impl.h:31: using RequestHandler =
nit: more specific typename? (sorry!)

[viettrungluu, 2016-05-11 23:16:33]

Thanks.

On 2016/05/11 23:09:35, vardhan wrote:
> lgtm w/ nit
> 
>
https://codereview.chromium.org/1973653002/diff/1/mojo/public/cpp/application...
> File mojo/public/cpp/application/service_provider_impl.h (right):
> 
>
https://codereview.chromium.org/1973653002/diff/1/mojo/public/cpp/application...
> mojo/public/cpp/application/service_provider_impl.h:31: using RequestHandler =
> nit: more specific typename? (sorry!)

Done.

I also added (in the comment) a usage example for AddServiceNew<I>().

[viettrungluu, 2016-05-11 23:17:18]

Description was changed from

==========
Add a new way of using ServiceProviderImpl without InterfaceFactory.

Instead, just take a factory function. This has a number of advantages:
* Classes don't have to implement InterfaceFactory<I> in order to
  "provide" services.
* Classes can (easily) instantiate impls in different ways (or
  instantiate different impls for the same service).

For now, the new method is called |AddServiceNew<I>()|, but I plan to
get rid of |AddService<I>()| and rename |AddServiceNew| to |AddService|.

Also, add a bunch of tests.

R=vardhan@google.com
==========

to

==========
Add a new way of using ServiceProviderImpl without InterfaceFactory.

Instead, just take a factory function. This has a number of advantages:
* Classes don't have to implement InterfaceFactory<I> in order to
  "provide" services.
* Classes can (easily) instantiate impls in different ways (or
  instantiate different impls for the same service).

For now, the new method is called |AddServiceNew<I>()|, but I plan to
get rid of |AddService<I>()| and rename |AddServiceNew| to |AddService|.

Also, add a bunch of tests.

R=vardhan@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/65138ce8c234734966a4e299d8f...
==========

[viettrungluu, 2016-05-11 23:17:20]

Committed patchset #2 (id:20001) manually as
65138ce8c234734966a4e299d8feba01d8c9ce07 (presubmit successful).