Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 197353003: Move ParseYieldExpression to ParserBase. (Closed)

Created:
6 years, 9 months ago by marja
Modified:
6 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Move ParseYieldExpression to ParserBase. R=mstarzinger@chromium.org BUG=v8:3126 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=19921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -45 lines) Patch
M src/parser.h View 3 chunks +1 line, -2 lines 0 comments Download
M src/parser.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M src/preparser.h View 7 chunks +38 lines, -2 lines 0 comments Download
M src/preparser.cc View 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
marja
rossberg, ptal
6 years, 9 months ago (2014-03-12 19:09:18 UTC) #1
marja
(reviewer swap, mstarzinger, ptal)
6 years, 9 months ago (2014-03-13 08:33:17 UTC) #2
Michael Starzinger
LGTM.
6 years, 9 months ago (2014-03-13 08:55:02 UTC) #3
marja
6 years, 9 months ago (2014-03-14 09:51:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r19921 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698