Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1973513002: Interceptors expect the receiver to always be an JSReceiver. (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Interceptors expect the receiver to always be an JSReceiver. BUG=chromium:609134 R=verwaest@chromium.org Committed: https://crrev.com/9c9708ac91314c8b485059d125eae2268325e119 Cr-Commit-Position: refs/heads/master@{#36203}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -18 lines) Patch
M src/ic/ic.cc View 1 2 chunks +14 lines, -4 lines 0 comments Download
M src/objects.cc View 4 chunks +31 lines, -10 lines 0 comments Download
M test/cctest/test-accessors.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jochen (gone - plz use gerrit)
4 years, 7 months ago (2016-05-11 14:17:25 UTC) #1
Toon Verwaest
https://codereview.chromium.org/1973513002/diff/1/src/ic/ic.cc File src/ic/ic.cc (right): https://codereview.chromium.org/1973513002/diff/1/src/ic/ic.cc#newcode1027 src/ic/ic.cc:1027: if (!receiver->IsJSReceiver()) break; This shouldn't be necessary given your ...
4 years, 7 months ago (2016-05-11 14:19:36 UTC) #2
jochen (gone - plz use gerrit)
ptal - now with test! I manually verified that it's failing without the changes
4 years, 7 months ago (2016-05-12 07:47:24 UTC) #3
Toon Verwaest
lgtm
4 years, 7 months ago (2016-05-12 11:00:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973513002/20001
4 years, 7 months ago (2016-05-12 11:03:32 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-12 11:04:59 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 11:06:23 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9c9708ac91314c8b485059d125eae2268325e119
Cr-Commit-Position: refs/heads/master@{#36203}

Powered by Google App Engine
This is Rietveld 408576698