[turbofan] Introduce new operators Float32SubPreserveNan and Float64SubPreserveNan for wasm.

[turbofan] Introduce new operators Float32SubPreserveNan and Float64SubPreserveNan for wasm.

The operators are needed because the wasm spec requires that nan bits are preserved.

R=titzer@chromium.org

Committed: https://crrev.com/481502dad9b45a38c86387d50cebe52f00b072ad
Cr-Commit-Position: refs/heads/master@{#36212}

[ahaas, 2016-05-11 13:46:06]

Description was changed from

==========
[turbofan] Introduce new operators Float32SubPreserveNan and
Float64SubPreserveNan for wasm.

R=titzer@chromium.org
==========

to

==========
[turbofan] Introduce new operators Float32SubPreserveNan and
Float64SubPreserveNan for wasm.

The operators are needed because the wasm spec requires that nan bits are
preserved.

R=titzer@chromium.org
==========

[titzer, 2016-05-12 13:02:47]

lgtm other than refactoring suggestion

https://codereview.chromium.org/1973493003/diff/1/src/compiler/arm/instructio...
File src/compiler/arm/instruction-selector-arm.cc (right):

https://codereview.chromium.org/1973493003/diff/1/src/compiler/arm/instructio...
src/compiler/arm/instruction-selector-arm.cc:1209: void
VisitFloat32SubHelper(InstructionSelector* selector, Node* node,
If you only factor out the part of the helper related to the common case, then
no boolean flag is needed.

[ahaas, 2016-05-12 13:26:16]

On 2016/05/12 at 13:02:47, titzer wrote:
> lgtm other than refactoring suggestion
> 
>
https://codereview.chromium.org/1973493003/diff/1/src/compiler/arm/instructio...
> File src/compiler/arm/instruction-selector-arm.cc (right):
> 
>
https://codereview.chromium.org/1973493003/diff/1/src/compiler/arm/instructio...
> src/compiler/arm/instruction-selector-arm.cc:1209: void
VisitFloat32SubHelper(InstructionSelector* selector, Node* node,
> If you only factor out the part of the helper related to the common case, then
no boolean flag is needed.

Done.

[ahaas, 2016-05-12 14:21:42]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-05-12 14:21:42]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1973493003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-05-12 14:21:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1973493003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1973493003/20001

[commit-bot: I haz the power, 2016-05-12 14:23:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-12 14:25:54]

Description was changed from

==========
[turbofan] Introduce new operators Float32SubPreserveNan and
Float64SubPreserveNan for wasm.

The operators are needed because the wasm spec requires that nan bits are
preserved.

R=titzer@chromium.org
==========

to

==========
[turbofan] Introduce new operators Float32SubPreserveNan and
Float64SubPreserveNan for wasm.

The operators are needed because the wasm spec requires that nan bits are
preserved.

R=titzer@chromium.org

Committed: https://crrev.com/481502dad9b45a38c86387d50cebe52f00b072ad
Cr-Commit-Position: refs/heads/master@{#36212}
==========

[commit-bot: I haz the power, 2016-05-12 14:25:55]

Patchset 2 (id:??) landed as
https://crrev.com/481502dad9b45a38c86387d50cebe52f00b072ad
Cr-Commit-Position: refs/heads/master@{#36212}