Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1973493002: Fix DBC build after my last change. (Closed)

Created:
4 years, 7 months ago by Florian Schneider
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix DBC build after my last change. Forgot to rename StringFromCharCode. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/d7c9421e329074ed35c18ad18ef7cbc81208c8d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/intermediate_language_dbc.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 7 months ago (2016-05-11 12:58:08 UTC) #2
Vyacheslav Egorov (Google)
LGTM
4 years, 7 months ago (2016-05-11 12:58:38 UTC) #3
Florian Schneider
4 years, 7 months ago (2016-05-11 12:59:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d7c9421e329074ed35c18ad18ef7cbc81208c8d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698