Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: components/os_crypt/key_storage_linux.h

Issue 1973483002: OSCrypt for POSIX uses libsecret to store a randomised encryption key. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed lsan failure Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/os_crypt/key_storage_linux.h
diff --git a/components/os_crypt/key_storage_linux.h b/components/os_crypt/key_storage_linux.h
new file mode 100644
index 0000000000000000000000000000000000000000..045afde78705be96c069d62c92e89dfbaf83381a
--- /dev/null
+++ b/components/os_crypt/key_storage_linux.h
@@ -0,0 +1,35 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_OS_CRYPT_KEY_STORAGE_LINUX_H_
+#define COMPONENTS_OS_CRYPT_KEY_STORAGE_LINUX_H_
+
+#include <memory>
+#include <string>
+
+#include "base/macros.h"
+
+// An API for retrieving OSCrypt's password from the system's password storage
+// service
+class KeyStorage {
Lei Zhang 2016/05/18 22:38:15 Should this be KeyStorageLinux?
cfroussios 2016/05/19 21:18:18 Done.
+ public:
+ KeyStorage() = default;
+ virtual ~KeyStorage() = default;
+
+ // Gets the encryption key from the OS password-managing library. If a key is
+ // not found, a new key will be generated, stored and returned.
+ virtual std::string GetKey() = 0;
+
+ // Load the key storage. False is returned if the service is not available.
Lei Zhang 2016/05/18 22:38:15 Grammar: - Load -> Loads - False is returned -> R
cfroussios 2016/05/19 21:18:18 Done.
+ virtual bool Init() = 0;
Lei Zhang 2016/05/18 22:38:15 Can we reorder the methods? I imagine users will c
cfroussios 2016/05/19 21:18:18 The code will call indeed call Init() first, but t
+
+ // Tries to load all known key storages. Returns the first that succeeds or
+ // null if none succeed.
+ static std::unique_ptr<KeyStorage> CreateService();
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(KeyStorage);
+};
+
+#endif // COMPONENTS_OS_CRYPT_KEY_STORAGE_LINUX_H_

Powered by Google App Engine
This is Rietveld 408576698