Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: components/os_crypt/key_storage_mock.cc

Issue 1973483002: OSCrypt for POSIX uses libsecret to store a randomised encryption key. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed lsan failure Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include <components/os_crypt/key_storage_mock.h>
Lei Zhang 2016/05/18 22:38:15 Yse quotes.
cfroussios 2016/05/19 21:18:18 Done.
6
7 #include "base/base64.h"
8 #include "base/rand_util.h"
9
10 KeyStorageMock::KeyStorageMock(std::string in_key) : key_(std::move(in_key)) {}
11
12 std::string KeyStorageMock::GetKey() {
13 if (key_.empty())
14 base::Base64Encode(base::RandBytesAsString(128 / 8), &key_);
Lei Zhang 2016/05/18 22:38:15 Ditto, is "128 / 8" necessary?
cfroussios 2016/05/19 21:18:18 Done.
Lei Zhang 2016/05/19 22:45:38 Wait, you kept it in the other place where I asked
cfroussios 2016/05/20 16:44:52 Done.
15 return key_;
16 }
17
18 bool KeyStorageMock::Init() {
19 return true;
20 }
21
22 void KeyStorageMock::ResetTo(std::string new_key) {
Lei Zhang 2016/05/18 22:38:15 How about making the parameter a base::StringPiece
cfroussios 2016/05/19 21:18:18 Done.
23 key_ = std::move(new_key);
24 }
25
26 std::string* KeyStorageMock::GetKeyPtr() {
27 return &key_;
28 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698