Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1973433002: Revert of [debugger] Prevent shared function info duplicates (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
Reviewers:
jgruber1, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debugger] Prevent shared function info duplicates (patchset #1 id:1 of https://codereview.chromium.org/1958153004/ ) Reason for revert: [Sheriff] Speculative revert for https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/6700 Yang can tell you how to do the blink rebase dance if it was this CL. Original issue's description: > [debugger] Prevent shared function info duplicates > > Clear the list of shared function infos attached to a script before > compiling for live edit in order to avoid duplicates. This was lost in > 058deb27132c97c62a99826455abc2bc87fae1b7. > > R=yangguo@chromium.org > BUG= > > Committed: https://crrev.com/592432977e6213364c243c396060c7b64687ddc3 > Cr-Commit-Position: refs/heads/master@{#36155} TBR=yangguo@chromium.org,jgruber@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/f4dd8ec37b96e9fb2c911d289aec6fc0180585a2 Cr-Commit-Position: refs/heads/master@{#36165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/compiler.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [debugger] Prevent shared function info duplicates
4 years, 7 months ago (2016-05-11 10:14:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973433002/1
4 years, 7 months ago (2016-05-11 10:14:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 10:15:09 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 10:16:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4dd8ec37b96e9fb2c911d289aec6fc0180585a2
Cr-Commit-Position: refs/heads/master@{#36165}

Powered by Google App Engine
This is Rietveld 408576698