Issue 19734014: cc: Add some unit tests for readbacks outside of the viewport.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19734014: cc: Add some unit tests for readbacks outside of the viewport. (Closed)

Created:
7 years, 5 months ago by danakj

Modified:
7 years, 5 months ago

Reviewers:
piman

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Add some unit tests for readbacks outside of the viewport. Adds a unit test and a pixel test that verify we can do a readback of an entire layer's subtree even though the layer is outside of the viewport. Depends on https://codereview.chromium.org/19664009/ Tests: LayerTreeHostCommonTest.VisibleContentRectInsideSurface LayerTreeHostReadbackPixelTest.ReadbackNonRootLayerOutsideViewport R=piman BUG=263512 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213459

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -0 lines)			Patch
	M	cc/trees/layer_tree_host_common_unittest.cc	View		1 chunk	+59 lines, -0 lines	0 comments	Download
	M	cc/trees/layer_tree_host_pixeltest_readback.cc	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/19734014/1

7 years, 5 months ago (2013-07-24 15:04:50 UTC) #3

Message was sent while issue was closed.

Change committed as 213459

Expand Messages | Collapse Messages