Support serialized dart:core in batch-mode

Support serialized dart:core in batch-mode

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/9ce98cada8d1fd3ddb0969a1bebb9ecaa2626502

[Johnni Winther, 2016-05-13 14:37:03]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Johnni Winther, 2016-05-17 13:08:07]

PTAL

[Siggi Cherem (dart-lang), 2016-05-17 21:30:16]

lgtm

https://codereview.chromium.org/1973333002/diff/1/pkg/compiler/lib/src/dart2j...
File pkg/compiler/lib/src/dart2js.dart (right):

https://codereview.chromium.org/1973333002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js.dart:799: if (serializedData == null) {
nit: consider adding a few functions at the end of this file with the logic of
this new code. For example, I'd add:
 - a function that creates the serialized data (the body of this `if`)
 - a function that compiles given serialized data
 - a function that does the wrapping you do here.
 
So the new code here would look more like this:

if (USE_SERIALIZED_DART_CORE) {
  compileFunc = _useSerializeDataForDartCore(compileFunc);
}

_useSerializeDataForDartCore(...) {
  String serializedData;
  return (...) async {
    serializedData ??= _generateSerializedDataForDartCore(...);
    return _compilerWithSerializedData(..., serializedData);
  };
}

...

[Johnni Winther, 2016-05-18 11:00:08]

https://codereview.chromium.org/1973333002/diff/1/pkg/compiler/lib/src/dart2j...
File pkg/compiler/lib/src/dart2js.dart (right):

https://codereview.chromium.org/1973333002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js.dart:799: if (serializedData == null) {
On 2016/05/17 21:30:15, Siggi Cherem (dart-lang) wrote:
> nit: consider adding a few functions at the end of this file with the logic of
> this new code. For example, I'd add:
>  - a function that creates the serialized data (the body of this `if`)
>  - a function that compiles given serialized data
>  - a function that does the wrapping you do here.
>  
> So the new code here would look more like this:
> 
> if (USE_SERIALIZED_DART_CORE) {
>   compileFunc = _useSerializeDataForDartCore(compileFunc);
> }
> 
> _useSerializeDataForDartCore(...) {
>   String serializedData;
>   return (...) async {
>     serializedData ??= _generateSerializedDataForDartCore(...);
>     return _compilerWithSerializedData(..., serializedData);
>   };
> }
> 
> ...

Done.

[Johnni Winther, 2016-05-18 11:05:14]

Description was changed from

==========
Support serialized dart:core in batch-mode
==========

to

==========
Support serialized dart:core in batch-mode

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9ce98cada8d1fd3ddb0969a1bebb9ecaa2626502
==========

[Johnni Winther, 2016-05-18 11:05:16]

Committed patchset #3 (id:40001) manually as
9ce98cada8d1fd3ddb0969a1bebb9ecaa2626502 (presubmit successful).