Handling LevelDB errors encountered after open.

content/browser/indexed_db/indexed_db_factory.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_factory.h"
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "content/browser/indexed_db/indexed_db_backing_store.h"
 #include "content/browser/indexed_db/indexed_db_context_impl.h"
+#include "content/browser/indexed_db/indexed_db_database_error.h"
 #include "content/browser/indexed_db/indexed_db_tracing.h"
 #include "content/browser/indexed_db/indexed_db_transaction_coordinator.h"
 #include "third_party/WebKit/public/platform/WebIDBDatabaseException.h"
 #include "webkit/common/database/database_identifier.h"
 
 using base::ASCIIToUTF16;
 
 namespace content {
 
 const int64 kBackingStoreGracePeriodMs = 2000;
@@ skipping 205 matching lines @@
 }
 
 void IndexedDBFactory::HandleBackingStoreFailure(const GURL& origin_url) {
   // NULL after ContextDestroyed() called, and in some unit tests.
   if (!context_)
     return;
   context_->ForceClose(origin_url,
                        IndexedDBContextImpl::FORCE_CLOSE_BACKING_STORE_FAILURE);
 }
 
+void IndexedDBFactory::HandleBackingStoreCorruption(
+    const GURL& origin_url,
+    const IndexedDBDatabaseError& error) {
+  // Make a copy of origin_url as this is likely a reference to a member of a
+  // backing store which this function will be deleting.
+  GURL saved_origin_url(origin_url);
+  DCHECK(context_);
+  base::FilePath path_base = context_->data_path();
+  IndexedDBBackingStore::RecordCorruptionInfo(

[jsbell, 2014/03/26 18:16:58]

Doesn't this write the file into the directory...

+      path_base, saved_origin_url, error);
+  HandleBackingStoreFailure(saved_origin_url);
+  if (!IndexedDBBackingStore::DestroyBackingStore(path_base, saved_origin_url)

[jsbell, 2014/03/26 18:16:58]

... which this deletes?

[cmumford, 2014/03/26 21:40:36]

No, see second reply in this review.

[jsbell, 2014/03/26 22:49:00]

Got it, thanks.

Maybe add a comment here that the directory will still exist since
DestroyBackingStore doesn't remove non-LDB files?

+           .ok())
+    DLOG(ERROR) << "Unable to delete backing store";
+}
+
 bool IndexedDBFactory::IsDatabaseOpen(const GURL& origin_url,
                                       const base::string16& name) const {
 
   return !!database_map_.count(IndexedDBDatabase::Identifier(origin_url, name));
 }
 
 bool IndexedDBFactory::IsBackingStoreOpen(const GURL& origin_url) const {
   return backing_store_map_.find(origin_url) != backing_store_map_.end();
 }
 
@@ skipping 118 matching lines @@
 
   std::pair<OriginDBMapIterator, OriginDBMapIterator> range =
       GetOpenDatabasesForOrigin(origin_url);
   for (OriginDBMapIterator it = range.first; it != range.second; ++it)
     count += it->second->ConnectionCount();
 
   return count;
 }
 
 }  // namespace content