Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 197333008: move rAc from behind flags (Closed)

Created:
6 years, 9 months ago by Evan Stade
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

move rAc from behind flags It was on by default anyway, and I don't see a reason to keep this flag around any more. BUG=none R=isherman@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262883

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -28 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 1 1 chunk +1 line, -5 lines 4 comments Download
M components/autofill/core/common/autofill_switches.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill/core/common/autofill_switches.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Evan Stade
6 years, 9 months ago (2014-03-26 01:46:49 UTC) #1
Ilya Sherman
I'm fine with removing these; but while you're here, maybe there's more we can remove? ...
6 years, 9 months ago (2014-03-26 03:57:50 UTC) #2
Evan Stade
https://codereview.chromium.org/197333008/diff/30001/chrome/renderer/chrome_render_process_observer.cc File chrome/renderer/chrome_render_process_observer.cc (right): https://codereview.chromium.org/197333008/diff/30001/chrome/renderer/chrome_render_process_observer.cc#newcode261 chrome/renderer/chrome_render_process_observer.cc:261: #if defined(ENABLE_AUTOFILL_DIALOG) On 2014/03/26 03:57:50, Ilya Sherman wrote: > ...
6 years, 9 months ago (2014-03-26 17:41:59 UTC) #3
Ilya Sherman
Fair enough. LGTM.
6 years, 9 months ago (2014-03-26 23:13:31 UTC) #4
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 9 months ago (2014-03-26 23:14:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/197333008/30001
6 years, 9 months ago (2014-03-26 23:14:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 23:43:03 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=57694
6 years, 9 months ago (2014-03-26 23:43:03 UTC) #8
Evan Stade
+Lei for OWNERS on chrome/renderer/
6 years, 9 months ago (2014-03-27 19:29:24 UTC) #9
Lei Zhang
lgtm
6 years, 9 months ago (2014-03-27 19:35:36 UTC) #10
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-08 21:32:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/197333008/30001
6 years, 8 months ago (2014-04-08 21:33:29 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-08 23:09:29 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 8 months ago (2014-04-08 23:09:29 UTC) #14
Evan Stade
6 years, 8 months ago (2014-04-10 01:04:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 manually as r262883 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698