Implement cloud policy invalidations using the invalidation service framework.

chrome/browser/invalidation/fake_invalidation_service.h

Index: chrome/browser/invalidation/fake_invalidation_service.h
diff --git a/chrome/browser/invalidation/fake_invalidation_service.h b/chrome/browser/invalidation/fake_invalidation_service.h
index 4b296ae3face0f8c52a963be9a79392a4472e534..48da39754f41d686a9ffbaf7c0a5db06adecd036 100644
--- a/chrome/browser/invalidation/fake_invalidation_service.h
+++ b/chrome/browser/invalidation/fake_invalidation_service.h
@@ -5,6 +5,8 @@
 #ifndef CHROME_BROWSER_INVALIDATION_FAKE_INVALIDATION_SERVICE_H_
 #define CHROME_BROWSER_INVALIDATION_FAKE_INVALIDATION_SERVICE_H_
 
+#include <list>
+
 #include "base/basictypes.h"
 #include "chrome/browser/invalidation/invalidation_service.h"
 #include "sync/notifier/invalidator_registrar.h"
@@ -33,14 +35,31 @@ class FakeInvalidationService : public InvalidationService {
   virtual syncer::InvalidatorState GetInvalidatorState() const OVERRIDE;
   virtual std::string GetInvalidatorClientId() const OVERRIDE;
 
-  void EmitInvalidationForTest(
+  const syncer::InvalidatorRegistrar& invalidator_registrar() const {
+    return invalidator_registrar_;
+  }
+  syncer::AckHandle EmitInvalidationForTest(
       const invalidation::ObjectId& object_id,
       int64 version,
       const std::string& payload);
 
+  // Determines if the given AckHandle has been acknowledged.
+  bool IsInvalidationAcknowledged(const syncer::AckHandle& ack_handle) const;
+
+  // Determines if AcknowledgeInvalidation was ever called with an invalid
+  // ObjectId/AckHandle pair.
+  bool ReceivedInvalidAcknowledgement() {
+    return received_invalid_acknowledgement_;
+  }
+
  private:
   std::string client_id_;
   syncer::InvalidatorRegistrar invalidator_registrar_;
+  typedef std::list<std::pair<syncer::AckHandle, invalidation::ObjectId> >

[Joao da Silva, 2013/07/23 20:44:47]

We tend to prefer vector to list, but I leave that to an owner of this code.

[Steve Condie, 2013/07/24 01:42:04]

I like list in this case for fast deletion in AcknowledgeInvalidation. What do
you think Richard?

[rlarocque, 2013/07/24 16:40:44]

This is test code, so I don't care much about algorithmic efficiency one way or
the other.  Either one looks OK to me.

+      AckHandleList;
+  AckHandleList unacknowledged_handles_;
+  AckHandleList acknowledged_handles_;
+  bool received_invalid_acknowledgement_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeInvalidationService);
 };