Implement cloud policy invalidations using the invalidation service framework.

chrome/browser/policy/cloud/user_cloud_policy_store_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/cloud/user_cloud_policy_store.h"
 
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_service.h"
@@ skipping 97 matching lines @@
 TEST_F(UserCloudPolicyStoreTest, LoadWithNoFile) {
   EXPECT_FALSE(store_->policy());
   EXPECT_TRUE(store_->policy_map().empty());
 
   EXPECT_CALL(observer_, OnStoreLoaded(store_.get()));
   store_->Load();
   RunUntilIdle();
 
   EXPECT_FALSE(store_->policy());
   EXPECT_TRUE(store_->policy_map().empty());
+  EXPECT_FALSE(store_->policy_changed());
 }
 
 TEST_F(UserCloudPolicyStoreTest, LoadWithInvalidFile) {
   EXPECT_FALSE(store_->policy());
   EXPECT_TRUE(store_->policy_map().empty());
 
   // Create a bogus file.
   ASSERT_TRUE(file_util::CreateDirectory(policy_file().DirName()));
   std::string bogus_data = "bogus_data";
   int size = bogus_data.size();
   ASSERT_EQ(size, file_util::WriteFile(policy_file(),
                                        bogus_data.c_str(),
                                        bogus_data.size()));
 
   ExpectError(store_.get(), CloudPolicyStore::STATUS_LOAD_ERROR);
   store_->Load();
   RunUntilIdle();
 
   EXPECT_FALSE(store_->policy());
   EXPECT_TRUE(store_->policy_map().empty());
+  EXPECT_FALSE(store_->policy_changed());
 }
 
 TEST_F(UserCloudPolicyStoreTest, LoadImmediatelyWithNoFile) {
   EXPECT_FALSE(store_->policy());
   EXPECT_TRUE(store_->policy_map().empty());
 
   EXPECT_CALL(observer_, OnStoreLoaded(store_.get()));
   store_->LoadImmediately();  // Should load without running the message loop.
 
   EXPECT_FALSE(store_->policy());
   EXPECT_TRUE(store_->policy_map().empty());
+  EXPECT_FALSE(store_->policy_changed());
 }
 
 TEST_F(UserCloudPolicyStoreTest, LoadImmediatelyWithInvalidFile) {
   EXPECT_FALSE(store_->policy());
   EXPECT_TRUE(store_->policy_map().empty());
 
   // Create a bogus file.
   ASSERT_TRUE(file_util::CreateDirectory(policy_file().DirName()));
   std::string bogus_data = "bogus_data";
   int size = bogus_data.size();
   ASSERT_EQ(size, file_util::WriteFile(policy_file(),
                                        bogus_data.c_str(),
                                        bogus_data.size()));
 
   ExpectError(store_.get(), CloudPolicyStore::STATUS_LOAD_ERROR);
   store_->LoadImmediately();  // Should load without running the message loop.
 
   EXPECT_FALSE(store_->policy());
   EXPECT_TRUE(store_->policy_map().empty());
+  EXPECT_FALSE(store_->policy_changed());
 }
 
 TEST_F(UserCloudPolicyStoreTest, Store) {
   EXPECT_FALSE(store_->policy());
   EXPECT_TRUE(store_->policy_map().empty());
 
   // Store a simple policy and make sure it ends up as the currently active
   // policy.
   EXPECT_CALL(observer_, OnStoreLoaded(store_.get()));
   store_->Store(policy_.policy());
@@ skipping 98 matching lines @@
   store2->AddObserver(&observer_);
   EXPECT_CALL(observer_, OnStoreLoaded(store2.get()));
   store2->LoadImmediately();  // Should load without running the message loop.
 
   ASSERT_TRUE(store2->policy());
   EXPECT_EQ(policy_.policy_data().SerializeAsString(),
             store2->policy()->SerializeAsString());
   VerifyPolicyMap(store2.get());
   EXPECT_EQ(CloudPolicyStore::STATUS_OK, store2->status());
   store2->RemoveObserver(&observer_);
+  EXPECT_TRUE(store2->policy_changed());
 }
 
 TEST_F(UserCloudPolicyStoreTest, StoreValidationError) {
   // Create an invalid policy (no policy type).
   policy_.policy_data().clear_policy_type();
   policy_.Build();
 
   // Store policy.
   ExpectError(store_.get(), CloudPolicyStore::STATUS_VALIDATION_ERROR);
   store_->Store(policy_.policy());
   RunUntilIdle();
   ASSERT_FALSE(store_->policy());
+  EXPECT_FALSE(store_->policy_changed());
 }
 
 TEST_F(UserCloudPolicyStoreTest, LoadValidationError) {
   // Force a validation error by changing the username after policy is stored.
   EXPECT_CALL(observer_, OnStoreLoaded(store_.get()));
   store_->Store(policy_.policy());
   RunUntilIdle();
 
   // Sign out, and sign back in as a different user, and try to load the profile
   // data (should fail due to mismatched username).
@@ skipping 33 matching lines @@
       new UserCloudPolicyStore(profile_.get(), policy_file()));
   store4->AddObserver(&observer_);
   ExpectError(store4.get(), CloudPolicyStore::STATUS_VALIDATION_ERROR);
   store4->Load();
   RunUntilIdle();
 
   ASSERT_FALSE(store4->policy());
   store4->RemoveObserver(&observer_);
 }
 
+TEST_F(UserCloudPolicyStoreTest, PolicyChanged) {
+  EXPECT_CALL(observer_, OnStoreLoaded(store_.get())).Times(7);
+  EXPECT_FALSE(store_->policy_changed());
+
+  // Clearing before storing should not result in a change.
+  store_->Clear();
+  EXPECT_FALSE(store_->policy_changed());
+
+  // Storing an initial policy should result in a change.
+  store_->Store(policy_.policy());
+  RunUntilIdle();
+  EXPECT_TRUE(store_->policy_changed());
+
+  // Storing the same policy should not result in a change.
+  store_->Store(policy_.policy());
+  RunUntilIdle();
+  EXPECT_FALSE(store_->policy_changed());
+
+  // Storing a modified policy should result in a change.
+  policy_.payload().mutable_urlblacklist()->mutable_value()->add_entries(
+      "build.chromium.org");
+  policy_.Build();
+  store_->Store(policy_.policy());
+  RunUntilIdle();
+  EXPECT_TRUE(store_->policy_changed());
+
+  // Storing the same policy should not result in a change.
+  store_->Store(policy_.policy());
+  RunUntilIdle();
+  EXPECT_FALSE(store_->policy_changed());
+
+  // Clearing the policy should result in a change.
+  store_->Clear();
+  EXPECT_TRUE(store_->policy_changed());
+
+  // Clearing the policy again shouldn't result in a change.
+  store_->Clear();
+  EXPECT_FALSE(store_->policy_changed());
+}
+
 }  // namespace
 
 }  // namespace policy