Implement cloud policy invalidations using the invalidation service framework.

chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/login/user.h"
 #include "chrome/browser/chromeos/login/user_manager.h"
 #include "chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h"
 #include "chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
+#include "chrome/browser/invalidation/invalidation_service_factory.h"
 #include "chrome/browser/policy/browser_policy_connector.h"
 #include "chrome/browser/policy/cloud/device_management_service.h"
 #include "chrome/browser/policy/cloud/resource_cache.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_switches.h"
 #include "chromeos/chromeos_paths.h"
 #include "chromeos/chromeos_switches.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "components/browser_context_keyed_service/browser_context_dependency_manager.h"
 #include "net/url_request/url_request_context_getter.h"
@@ skipping 34 matching lines @@
 scoped_ptr<UserCloudPolicyManagerChromeOS>
     UserCloudPolicyManagerFactoryChromeOS::CreateForProfile(
         Profile* profile,
         bool force_immediate_load) {
   return GetInstance()->CreateManagerForProfile(profile, force_immediate_load);
 }
 
 UserCloudPolicyManagerFactoryChromeOS::UserCloudPolicyManagerFactoryChromeOS()
     : BrowserContextKeyedBaseFactory(
         "UserCloudPolicyManagerChromeOS",
-        BrowserContextDependencyManager::GetInstance()) {}
+        BrowserContextDependencyManager::GetInstance()) {
+  DependsOn(invalidation::InvalidationServiceFactory::GetInstance());

[Joao da Silva, 2013/07/24 15:34:07]

I just realized that we can't do this.

Basically the cloud policy manager is the very first PKS created, because the
PrefService depends on it (and ALL the other PKSs depend on having prefs ready).
So if we do this then the InvalidationService gets created before the cloud
policy manager is ready, and before the prefs are ready.

Fortunately there's an easy fix: just make the cloud_policy_invalidator a PKS as
well. I'll comment more on this elsewhere.

[Steve Condie, 2013/07/25 01:18:08]

Done.

+}
 
 UserCloudPolicyManagerFactoryChromeOS::
     ~UserCloudPolicyManagerFactoryChromeOS() {}
 
 UserCloudPolicyManagerChromeOS*
     UserCloudPolicyManagerFactoryChromeOS::GetManagerForProfile(
         Profile* profile) {
   // Get the manager for the original profile, since the PolicyService is
   // also shared between the incognito Profile and the original Profile.
   ManagerMap::const_iterator it = managers_.find(profile->GetOriginalProfile());
@@ skipping 54 matching lines @@
 
   scoped_ptr<CloudPolicyStore> store(
       new UserCloudPolicyStoreChromeOS(
           chromeos::DBusThreadManager::Get()->GetCryptohomeClient(),
           chromeos::DBusThreadManager::Get()->GetSessionManagerClient(),
           username, policy_key_dir, token_cache_file, policy_cache_file));
   scoped_ptr<ResourceCache> resource_cache;
   if (command_line->HasSwitch(switches::kEnableComponentCloudPolicy))
     resource_cache.reset(new ResourceCache(resource_cache_dir));
   scoped_ptr<UserCloudPolicyManagerChromeOS> manager(
-      new UserCloudPolicyManagerChromeOS(store.Pass(),
-                                         resource_cache.Pass(),
-                                         wait_for_initial_policy));
+      new UserCloudPolicyManagerChromeOS(
+          store.Pass(),
+          resource_cache.Pass(),
+          wait_for_initial_policy,
+          invalidation::InvalidationServiceFactory::GetForProfile(profile)));
   manager->Init();
   manager->Connect(g_browser_process->local_state(),
                    device_management_service,
                    g_browser_process->system_request_context(),
                    affiliation);
 
   DCHECK(managers_.find(profile) == managers_.end());
   managers_[profile] = manager.get();
   return manager.Pass();
 }
@@ skipping 15 matching lines @@
   BrowserContextKeyedBaseFactory::BrowserContextDestroyed(context);
 }
 
 void UserCloudPolicyManagerFactoryChromeOS::SetEmptyTestingFactory(
     content::BrowserContext* context) {}
 
 void UserCloudPolicyManagerFactoryChromeOS::CreateServiceNow(
     content::BrowserContext* context) {}
 
 }  // namespace policy