Implement cloud policy invalidations using the invalidation service framework.

chrome/browser/policy/cloud/user_cloud_policy_store.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/cloud/user_cloud_policy_store.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "chrome/browser/policy/proto/cloud/device_management_backend.pb.h"
 #include "chrome/browser/policy/proto/cloud/device_management_local.pb.h"
@@ skipping 52 matching lines @@
     return result;
   }
 
   result.status = policy::LOAD_RESULT_SUCCESS;
   return result;
 }
 
 // Stores policy to the backing file (must be called via a task on
 // the FILE thread).
 void StorePolicyToDiskOnFileThread(const base::FilePath& path,
-                                   const em::PolicyFetchResponse& policy) {
+    const em::PolicyFetchResponse& policy) {

[Joao da Silva, 2013/07/23 20:44:47]

This is chromium style :-)

You may give clang-format a try, it has a chromium-style flag:

http://clang.llvm.org/docs/ClangFormat.html

[Steve Condie, 2013/07/24 01:42:04]

Whoops, didn't mean to change that. In a previous version of the code I modified
this function to have a return value (so that OnStoreLoaded would only be called
after a successful disk store). When I reverted that apparently I didn't fully
revert the spacing.

   DVLOG(1) << "Storing policy to " << path.value();
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
   std::string data;
   if (!policy.SerializeToString(&data)) {
     DLOG(WARNING) << "Failed to serialize policy data";
     return;
   }
 
   if (!file_util::CreateDirectory(path.DirName())) {
     DLOG(WARNING) << "Failed to create directory " << path.DirName().value();
@@ skipping 36 matching lines @@
 }
 
 void UserCloudPolicyStore::Clear() {
   content::BrowserThread::PostTask(
       content::BrowserThread::FILE, FROM_HERE,
       base::Bind(base::IgnoreResult(&base::DeleteFile),
                  backing_file_path_,
                  false));
   policy_.reset();
   policy_map_.Clear();
+  SetPolicyHashValue(0);

[Joao da Silva, 2013/07/23 20:44:47]

NotifyStoreLoaded() could compute this

[Steve Condie, 2013/07/24 01:42:04]

Done.

   NotifyStoreLoaded();
 }
 
 void UserCloudPolicyStore::Load() {
   DVLOG(1) << "Initiating policy load from disk";
   // Cancel any pending Load/Store/Validate operations.
   weak_factory_.InvalidateWeakPtrs();
 
   // Start a new Load operation and have us get called back when it is
   // complete.
@@ skipping 41 matching lines @@
     DVLOG(1) << "Validation failed: status=" << validation_status_;
     status_ = STATUS_VALIDATION_ERROR;
     NotifyStoreError();
     return;
   }
 
   DVLOG(1) << "Validation succeeded - installing policy with dm_token: " <<
       validator->policy_data()->request_token();
   DVLOG(1) << "Device ID: " << validator->policy_data()->device_id();
 
-  InstallPolicy(validator->policy_data().Pass(), validator->payload().Pass());
+  InstallPolicy(
+      validator->policy_data().Pass(),
+      validator->payload().Pass(),
+      validator->hash_value());

[Joao da Silva, 2013/07/23 20:44:47]

NotifyStoreLoaded can do this :-)

[Steve Condie, 2013/07/24 01:42:04]

Done.

   status_ = STATUS_OK;
   NotifyStoreLoaded();
 }
 
 void UserCloudPolicyStore::Store(const em::PolicyFetchResponse& policy) {
   // Stop any pending requests to store policy, then validate the new policy
   // before storing it.
   weak_factory_.InvalidateWeakPtrs();
   scoped_ptr<em::PolicyFetchResponse> policy_copy(
       new em::PolicyFetchResponse(policy));
@@ skipping 42 matching lines @@
     NotifyStoreError();
     return;
   }
 
   // Persist the validated policy (just fire a task - don't bother getting a
   // reply because we can't do anything if it fails).
   content::BrowserThread::PostTask(
       content::BrowserThread::FILE, FROM_HERE,
       base::Bind(&StorePolicyToDiskOnFileThread,
                  backing_file_path_, *validator->policy()));
-  InstallPolicy(validator->policy_data().Pass(), validator->payload().Pass());
+  InstallPolicy(
+      validator->policy_data().Pass(),
+      validator->payload().Pass(),
+      validator->hash_value());

[Joao da Silva, 2013/07/23 20:44:47]

Same

[Steve Condie, 2013/07/24 01:42:04]

Done.

   status_ = STATUS_OK;
   NotifyStoreLoaded();
 }
 
 }  // namespace policy