Implement cloud policy invalidations using the invalidation service framework.

chrome/browser/policy/cloud/cloud_policy_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/cloud/cloud_policy_manager.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
+#include "chrome/browser/policy/cloud/cloud_policy_invalidator.h"
+#include "chrome/browser/policy/cloud/cloud_policy_refresh_scheduler.h"
 #include "chrome/browser/policy/cloud/cloud_policy_service.h"
 #include "chrome/browser/policy/policy_bundle.h"
 #include "chrome/browser/policy/policy_map.h"
 
 namespace policy {
 
 CloudPolicyManager::CloudPolicyManager(const PolicyNamespaceKey& policy_ns_key,
                                        CloudPolicyStore* cloud_policy_store)
     : core_(policy_ns_key, cloud_policy_store),
       waiting_for_policy_refresh_(false) {
   store()->AddObserver(this);
 
   // If the underlying store is already initialized, publish the loaded
   // policy. Otherwise, request a load now.
   if (store()->is_initialized())
     CheckAndPublishPolicy();
   else
     store()->Load();
 }
 
 CloudPolicyManager::~CloudPolicyManager() {}
 
 void CloudPolicyManager::Shutdown() {
+  invalidator_.reset();
   core_.Disconnect();
   store()->RemoveObserver(this);
   ConfigurationPolicyProvider::Shutdown();
 }
 
 bool CloudPolicyManager::IsInitializationComplete(PolicyDomain domain) const {
   if (domain == POLICY_DOMAIN_CHROME)
     return store()->is_initialized();
   return true;
 }
@@ skipping 22 matching lines @@
   CheckAndPublishPolicy();
 }
 
 void CloudPolicyManager::CheckAndPublishPolicy() {
   if (IsInitializationComplete(POLICY_DOMAIN_CHROME) &&
       !waiting_for_policy_refresh_) {
     UpdatePolicy(CreatePolicyBundle());
   }
 }
 
+void CloudPolicyManager::CreateInvalidator(
+    invalidation::InvalidationService* service) {

[Joao da Silva, 2013/07/23 20:44:47]

You can check the command line flag here.

Also, skip that command line flag on OS_ANDROID and always initialize this on
that platform.

[Steve Condie, 2013/07/24 01:42:04]

Done.

+  invalidator_.reset(new CloudPolicyInvalidator(
+      service,
+      client(),
+      store(),
+      base::MessageLoop::current()->message_loop_proxy(),
+      base::Bind(
+          &CloudPolicyRefreshScheduler::RefreshForInvalidation,

[Joao da Silva, 2013/07/23 20:44:47]

CloudPolicyRefreshScheduler::RefreshSoon

Actually, the invalidator should also tell the refresh_scheduler when the
invalidation_service is online/offline, so we could remove this callback and
just pass a handle to the scheduler directly here. WDYT?

[Steve Condie, 2013/07/24 01:42:04]

Changed this so that instead of passing in a single closure, you pass in a
reference to a CloudPolicyInvalidationHandler, which provides both the
invalidation and the state changed functions.

+          base::Unretained(core()->refresh_scheduler()))));
+}
+
+void CloudPolicyManager::UnregisterInvalidator() {
+  if (invalidator_.get()) {
+    invalidator_->Unregister();
+    invalidator_.reset();
+  }
+}
+
 scoped_ptr<PolicyBundle> CloudPolicyManager::CreatePolicyBundle() {
   scoped_ptr<PolicyBundle> bundle(new PolicyBundle);
   bundle->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
       .CopyFrom(store()->policy_map());
   return bundle.Pass();
 }
 
 void CloudPolicyManager::OnRefreshComplete(bool success) {
   waiting_for_policy_refresh_ = false;
   CheckAndPublishPolicy();
 }
 
 }  // namespace policy