Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Unified Diff: chrome/browser/password_manager/account_chooser_dialog_android.cc

Issue 1973293002: [Smart Lock] Adds UMA Metrics for actions on Account Chooser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/account_chooser_dialog_android.cc
diff --git a/chrome/browser/password_manager/account_chooser_dialog_android.cc b/chrome/browser/password_manager/account_chooser_dialog_android.cc
index f33ed44f2c5c104c8cfaf8066367675aa088bd40..e6f6a81b04951b4e406b83fd747d6f6aef7caa18 100644
--- a/chrome/browser/password_manager/account_chooser_dialog_android.cc
+++ b/chrome/browser/password_manager/account_chooser_dialog_android.cc
@@ -20,6 +20,7 @@
#include "components/browser_sync/browser/profile_sync_service.h"
#include "components/password_manager/core/browser/password_bubble_experiment.h"
#include "components/password_manager/core/browser/password_manager_constants.h"
+#include "components/password_manager/core/browser/password_manager_metrics_util.h"
#include "components/password_manager/core/browser/password_ui_utils.h"
#include "components/password_manager/core/common/credential_manager_types.h"
#include "jni/AccountChooserDialog_jni.h"
@@ -225,8 +226,13 @@ void AccountChooserDialogAndroid::ChooseCredential(
using namespace password_manager;
if (type == CredentialType::CREDENTIAL_TYPE_EMPTY) {
passwords_data_.ChooseCredential(nullptr);
+ password_manager::metrics_util::LogAccountChooserUserAction(
+ password_manager::metrics_util::ACCOUNT_CHOOSER_DISMISSED);
+
return;
}
+ password_manager::metrics_util::LogAccountChooserUserAction(
+ password_manager::metrics_util::ACCOUNT_CHOOSER_CREDENTIAL_CHOSEN);
const auto& credentials_forms =
(type == CredentialType::CREDENTIAL_TYPE_PASSWORD)
? local_credentials_forms()

Powered by Google App Engine
This is Rietveld 408576698