content/browser/top_document_isolation_browsertest.cc - Issue 1973283002: Disable flaky TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2 on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/top_document_isolation_browsertest.cc

Issue 1973283002: Disable flaky TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2 on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/top_document_isolation_browsertest.cc

diff --git a/content/browser/top_document_isolation_browsertest.cc b/content/browser/top_document_isolation_browsertest.cc

index 9eab56436950fd835ffe371c48b8b5f7cd9ef922..72d87060f4cfb686561dab8c9dcc57a6f3c68db5 100644

--- a/content/browser/top_document_isolation_browsertest.cc

+++ b/content/browser/top_document_isolation_browsertest.cc

@@ -278,8 +278,8 @@ IN_PROC_BROWSER_TEST_F(TopDocumentIsolationTest,

DepictFrameTree(root()));

}

-// Flaky on Mac. See http://crbug.com/611300.

-#if defined(OS_MACOSX)

+// Flaky on Mac and Windows. See http://crbug.com/611300.

+#if defined(OS_MACOSX) || defined(OS_WIN)

#define MAYBE_NavigateToSubframeSiteWithPopup2 \

DISABLED_NavigateToSubframeSiteWithPopup2

#else

« no previous file with comments | « no previous file | no next file » | no next file with comments »