Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1973213002: Online 'SSA conversion' of mutable parameters. (Closed)

Created:
4 years, 7 months ago by sra1
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Online 'SSA conversion' of mutable parameters. The builder creates mutable parameters in functions containing try-catch. This change cleans this up in the usual case where the parameter is not assigned. The effect is improved SSA type propagation. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/3c82f05ca65c7b327c41b4864a73771d31300e94

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M pkg/compiler/lib/src/ssa/optimize.dart View 1 1 chunk +18 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
sra1
4 years, 4 months ago (2016-08-19 16:14:23 UTC) #1
Siggi Cherem (dart-lang)
lgtm
4 years, 4 months ago (2016-08-19 16:24:55 UTC) #2
sra1
4 years, 3 months ago (2016-08-23 00:29:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3c82f05ca65c7b327c41b4864a73771d31300e94 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698