Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1973193002: [esnext] Async function toString support (Closed)

Created:
4 years, 7 months ago by Dan Ehrenberg
Modified:
4 years, 7 months ago
Reviewers:
caitp (gmail)
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@async-run3
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[esnext] Async function toString support BUG=v8:4483 Committed: https://crrev.com/4afe89a7daba26f915f61765768b9d49295cf10e Cr-Commit-Position: refs/heads/master@{#36265}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix more toString cases #

Patch Set 3 : Rebase #

Patch Set 4 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M src/objects.cc View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download
M test/mjsunit/harmony/async-await-basic.js View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973193002/1
4 years, 7 months ago (2016-05-13 00:37:41 UTC) #2
Dan Ehrenberg
4 years, 7 months ago (2016-05-13 00:38:41 UTC) #4
caitp (gmail)
https://codereview.chromium.org/1973193002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1973193002/diff/1/src/objects.cc#newcode12201 src/objects.cc:12201: builder.AppendCString("async function "); How do we make this work ...
4 years, 7 months ago (2016-05-13 01:01:29 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 01:09:25 UTC) #7
Dan Ehrenberg
https://codereview.chromium.org/1973193002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1973193002/diff/1/src/objects.cc#newcode12201 src/objects.cc:12201: builder.AppendCString("async function "); On 2016/05/13 at 01:01:29, caitp wrote: ...
4 years, 7 months ago (2016-05-13 19:10:32 UTC) #8
caitp (gmail)
lgtm --- surprised the arrow case works out of the box, but I see it ...
4 years, 7 months ago (2016-05-13 19:13:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973193002/20001
4 years, 7 months ago (2016-05-17 00:40:01 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/17681) v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-05-17 00:41:33 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973193002/40001
4 years, 7 months ago (2016-05-17 00:52:21 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15297)
4 years, 7 months ago (2016-05-17 00:55:32 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973193002/60001
4 years, 7 months ago (2016-05-17 00:58:42 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-17 01:27:30 UTC) #21
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 01:29:02 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4afe89a7daba26f915f61765768b9d49295cf10e
Cr-Commit-Position: refs/heads/master@{#36265}

Powered by Google App Engine
This is Rietveld 408576698