|
|
Created:
4 years, 7 months ago by Dan Ehrenberg Modified:
4 years, 7 months ago Reviewers:
caitp (gmail) CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@async-run3 Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[esnext] Async function toString support
BUG=v8:4483
Committed: https://crrev.com/4afe89a7daba26f915f61765768b9d49295cf10e
Cr-Commit-Position: refs/heads/master@{#36265}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix more toString cases #Patch Set 3 : Rebase #Patch Set 4 : style #Messages
Total messages: 23 (10 generated)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973193002/1
littledan@chromium.org changed reviewers: + caitpotter88@gmail.com
https://codereview.chromium.org/1973193002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1973193002/diff/1/src/objects.cc#newcode12201 src/objects.cc:12201: builder.AppendCString("async function "); How do we make this work for async arrows and methods?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1973193002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1973193002/diff/1/src/objects.cc#newcode12201 src/objects.cc:12201: builder.AppendCString("async function "); On 2016/05/13 at 01:01:29, caitp wrote: > How do we make this work for async arrows and methods? Fixed (arrows already worked) and added tests
lgtm --- surprised the arrow case works out of the box, but I see it does
The CQ bit was checked by littledan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973193002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...) v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/5793) v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/5807) v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/7332)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973193002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15297)
The CQ bit was checked by littledan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from caitpotter88@gmail.com Link to the patchset: https://codereview.chromium.org/1973193002/#ps60001 (title: "style")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973193002/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [esnext] Async function toString support BUG=v8:4483 ========== to ========== [esnext] Async function toString support BUG=v8:4483 Committed: https://crrev.com/4afe89a7daba26f915f61765768b9d49295cf10e Cr-Commit-Position: refs/heads/master@{#36265} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/4afe89a7daba26f915f61765768b9d49295cf10e Cr-Commit-Position: refs/heads/master@{#36265} |