third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp - Issue 1973153004: Fix FontCacheKey-keyed HashMap usage in core/css

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

Issue 1973153004: Fix FontCacheKey-keyed HashMap usage in core/css (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: +comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp b/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

index b542e535169b0c263c4105f8a3c3defd29327e48..975a90a0f3864ef61a6c3df57f21146379983130 100644

--- a/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

+++ b/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

@@ -107,7 +107,7 @@ PassRefPtr<FontData> CSSSegmentedFontFace::getFontData(const FontDescription& fo

FontTraits desiredTraits = fontDescription.traits();

FontCacheKey key = fontDescription.cacheKey(FontFaceCreationParams(), desiredTraits);

- RefPtr<SegmentedFontData>& fontData = m_fontDataTable.add(key.hash(), nullptr).storedValue->value;

+ RefPtr<SegmentedFontData>& fontData = m_fontDataTable.add(key, nullptr).storedValue->value;

if (fontData && fontData->numFaces())

return fontData; // No release, we have a reference to an object in the cache which should retain the ref count it has.

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSSegmentedFontFace.h ('k') | no next file » | no next file with comments »