Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSFontFaceSource.h

Issue 1973153004: Fix FontCacheKey-keyed HashMap usage in core/css (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: +comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef CSSFontFaceSource_h 26 #ifndef CSSFontFaceSource_h
27 #define CSSFontFaceSource_h 27 #define CSSFontFaceSource_h
28 28
29 #include "core/CoreExport.h"
30 #include "platform/fonts/FontCacheKey.h"
29 #include "platform/heap/Handle.h" 31 #include "platform/heap/Handle.h"
30 #include "wtf/Allocator.h" 32 #include "wtf/Allocator.h"
31 #include "wtf/HashMap.h" 33 #include "wtf/HashMap.h"
32 34
33 namespace blink { 35 namespace blink {
34 36
35 class CSSFontFace; 37 class CSSFontFace;
36 class FontDescription; 38 class FontDescription;
37 class SimpleFontData; 39 class SimpleFontData;
38 40
39 class CSSFontFaceSource : public GarbageCollectedFinalized<CSSFontFaceSource> { 41 class CORE_EXPORT CSSFontFaceSource : public GarbageCollectedFinalized<CSSFontFa ceSource> {
40 WTF_MAKE_NONCOPYABLE(CSSFontFaceSource); 42 WTF_MAKE_NONCOPYABLE(CSSFontFaceSource);
41 public: 43 public:
42 virtual ~CSSFontFaceSource(); 44 virtual ~CSSFontFaceSource();
43 45
44 virtual bool isLocal() const { return false; } 46 virtual bool isLocal() const { return false; }
45 virtual bool isLoading() const { return false; } 47 virtual bool isLoading() const { return false; }
46 virtual bool isLoaded() const { return true; } 48 virtual bool isLoaded() const { return true; }
47 virtual bool isValid() const { return true; } 49 virtual bool isValid() const { return true; }
48 50
49 void setFontFace(CSSFontFace* face) { m_face = face; } 51 void setFontFace(CSSFontFace* face) { m_face = face; }
50 52
51 PassRefPtr<SimpleFontData> getFontData(const FontDescription&); 53 PassRefPtr<SimpleFontData> getFontData(const FontDescription&);
52 54
53 virtual bool isLocalFontAvailable(const FontDescription&) { return false; } 55 virtual bool isLocalFontAvailable(const FontDescription&) { return false; }
54 virtual void beginLoadIfNeeded() { } 56 virtual void beginLoadIfNeeded() { }
55 57
56 // For UMA reporting 58 // For UMA reporting
57 virtual bool hadBlankText() { return false; } 59 virtual bool hadBlankText() { return false; }
58 60
59 DECLARE_VIRTUAL_TRACE(); 61 DECLARE_VIRTUAL_TRACE();
60 62
61 protected: 63 protected:
62 CSSFontFaceSource(); 64 CSSFontFaceSource();
63 virtual PassRefPtr<SimpleFontData> createFontData(const FontDescription&) = 0; 65 virtual PassRefPtr<SimpleFontData> createFontData(const FontDescription&) = 0;
64 66
65 using FontDataTable = HashMap<unsigned, RefPtr<SimpleFontData>>; // The hash key is composed of size synthetic styles. 67 using FontDataTable = HashMap<FontCacheKey, RefPtr<SimpleFontData>, FontCach eKeyHash, FontCacheKeyTraits>;
66 68
67 Member<CSSFontFace> m_face; // Our owning font face. 69 Member<CSSFontFace> m_face; // Our owning font face.
68 FontDataTable m_fontDataTable; 70 FontDataTable m_fontDataTable;
69 }; 71 };
70 72
71 } // namespace blink 73 } // namespace blink
72 74
73 #endif 75 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/css/CSSFontFaceSource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698