Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1973153003: OSX: Allow to read "/System/Library/LinguisticData" in sandbox (Closed)

Created:
4 years, 7 months ago by kojii
Modified:
4 years, 7 months ago
Reviewers:
Robert Sesek, eae
CC:
chromium-reviews, darin-cc_chromium.org, eae, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OSX: Allow to read "/System/Library/LinguisticData" in sandbox The following hyphenation APIs requires to read files in "/System/Library/LinguisticData". - CFStringIsHyphenationAvailableForLocale - CFStringGetHyphenationLocationBeforeIndex BUG=605840 Committed: https://crrev.com/4fe1179928340ac685c0680a1e85a8fd79f72c40 Cr-Commit-Position: refs/heads/master@{#393554}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/renderer/renderer.sb View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (5 generated)
kojii
PTAL.
4 years, 7 months ago (2016-05-12 23:22:58 UTC) #3
kojii
https://codereview.chromium.org/1973153003/diff/1/content/renderer/renderer.sb File content/renderer/renderer.sb (right): https://codereview.chromium.org/1973153003/diff/1/content/renderer/renderer.sb#newcode51 content/renderer/renderer.sb:51: (allow file-read* (subpath "/System/Library/LinguisticData")) Changed from the original for ...
4 years, 7 months ago (2016-05-12 23:27:28 UTC) #4
Robert Sesek
lgtm
4 years, 7 months ago (2016-05-13 16:48:22 UTC) #5
kojii
Thanks!
4 years, 7 months ago (2016-05-13 16:49:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973153003/1
4 years, 7 months ago (2016-05-13 16:49:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 16:53:57 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4fe1179928340ac685c0680a1e85a8fd79f72c40 Cr-Commit-Position: refs/heads/master@{#393554}
4 years, 7 months ago (2016-05-13 16:55:55 UTC) #11
eae
4 years, 7 months ago (2016-05-13 17:33:28 UTC) #13
Message was sent while issue was closed.
Yay, thank you.

Powered by Google App Engine
This is Rietveld 408576698