Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1728)

Unified Diff: content/renderer/media/media_recorder_handler.cc

Issue 1973143002: Allow MediaRecorder to record Muted streams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_recorder_handler.cc
diff --git a/content/renderer/media/media_recorder_handler.cc b/content/renderer/media/media_recorder_handler.cc
index aa416728d1ad34b6bf851f0877ab461c5e31a803..dd838d25b2cb1c7da7b4ff2754332d69e32fcf84 100644
--- a/content/renderer/media/media_recorder_handler.cc
+++ b/content/renderer/media/media_recorder_handler.cc
@@ -135,15 +135,15 @@ bool MediaRecorderHandler::start(int timeslice) {
return false;
}
- const bool use_video_tracks = !video_tracks.isEmpty() &&
- video_tracks[0].isEnabled() &&
- video_tracks[0].source().getReadyState() ==
- blink::WebMediaStreamSource::ReadyStateLive;
- const bool use_audio_tracks = !audio_tracks.isEmpty() &&
- MediaStreamAudioTrack::From(audio_tracks[0]) &&
- audio_tracks[0].isEnabled() &&
- audio_tracks[0].source().getReadyState() ==
- blink::WebMediaStreamSource::ReadyStateLive;
+ const bool use_video_tracks =
+ !video_tracks.isEmpty() && video_tracks[0].isEnabled() &&
+ video_tracks[0].source().getReadyState() !=
+ blink::WebMediaStreamSource::ReadyStateEnded;
+ const bool use_audio_tracks =
+ !audio_tracks.isEmpty() && MediaStreamAudioTrack::From(audio_tracks[0]) &&
+ audio_tracks[0].isEnabled() &&
+ audio_tracks[0].source().getReadyState() !=
+ blink::WebMediaStreamSource::ReadyStateEnded;
webm_muxer_.reset(new media::WebmMuxer(
use_vp9_ ? media::kCodecVP9 : media::kCodecVP8, use_video_tracks,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698