✀ Remove postMessage plumbing for swappedout:// ✀

✀ Remove postMessage plumbing for swappedout:// ✀

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/b4a1a32e9393518ebd63c52f021eb5142954c9d6
Cr-Commit-Position: refs/heads/master@{#394016}

[dcheng, 2016-05-12 22:07:57]

Description was changed from

==========
Remove postMessage plumbing for swappedout://

BUG=???
==========

to

==========
Remove postMessage plumbing for swappedout://

BUG=???
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[dcheng, 2016-05-12 22:08:22]

Description was changed from

==========
Remove postMessage plumbing for swappedout://

BUG=???
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove postMessage plumbing for swappedout://

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[dcheng, 2016-05-12 22:08:22]

dcheng@chromium.org changed reviewers:
+ alexmos@chromium.org, lukasza@chromium.org

[dcheng, 2016-05-12 22:08:42]

dcheng@chromium.org changed reviewers:
- lukasza@chromium.org

[dcheng, 2016-05-12 22:12:47]

Description was changed from

==========
Remove postMessage plumbing for swappedout://

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
✀ Remove postMessage plumbing for swappedout:// ✀

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[alexmos, 2016-05-13 21:30:07]

LGTM, thanks for the cleanup!

https://codereview.chromium.org/1973133002/diff/40001/content/renderer/render...
File content/renderer/render_view_browsertest.cc (right):

https://codereview.chromium.org/1973133002/diff/40001/content/renderer/render...
content/renderer/render_view_browsertest.cc:54: #include
"content/renderer/render_frame_proxy.h"
nit: not needed?

https://codereview.chromium.org/1973133002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/events/intercept-postmessage.html
(left):

https://codereview.chromium.org/1973133002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/intercept-postmessage.html:43:
</html>
Wow, I had no idea this test even existed.

https://codereview.chromium.org/1973133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/RemoteFrameClient.h (right):

https://codereview.chromium.org/1973133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/RemoteFrameClient.h:28: virtual void
willCheckAndDispatchMessageEvent(MessageEvent*, PassRefPtr<SecurityOrigin>
target, LocalFrame* sourceFrame) const = 0;
Now that this is only forwarding a message without any checking along the way,
the name sounds a bit out of date. WDYT about simplifying it to something like
forwardMessageEvent, all the way to RenderFrameProxy?

[dcheng, 2016-05-13 22:00:48]

https://codereview.chromium.org/1973133002/diff/40001/content/renderer/render...
File content/renderer/render_view_browsertest.cc (right):

https://codereview.chromium.org/1973133002/diff/40001/content/renderer/render...
content/renderer/render_view_browsertest.cc:54: #include
"content/renderer/render_frame_proxy.h"
On 2016/05/13 at 21:30:07, alexmos wrote:
> nit: not needed?

There's a call to RenderFrameProxy::FromRoutingID in this test.

https://codereview.chromium.org/1973133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/RemoteFrameClient.h (right):

https://codereview.chromium.org/1973133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/RemoteFrameClient.h:28: virtual void
willCheckAndDispatchMessageEvent(MessageEvent*, PassRefPtr<SecurityOrigin>
target, LocalFrame* sourceFrame) const = 0;
On 2016/05/13 at 21:30:07, alexmos wrote:
> Now that this is only forwarding a message without any checking along the way,
the name sounds a bit out of date. WDYT about simplifying it to something like
forwardMessageEvent, all the way to RenderFrameProxy?

I've renamed it to forwardPostMessage, since I think that's the only thing it's
used for. WDYT?

[alexmos, 2016-05-13 23:11:28]

https://codereview.chromium.org/1973133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/RemoteFrameClient.h (right):

https://codereview.chromium.org/1973133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/RemoteFrameClient.h:28: virtual void
willCheckAndDispatchMessageEvent(MessageEvent*, PassRefPtr<SecurityOrigin>
target, LocalFrame* sourceFrame) const = 0;
On 2016/05/13 22:00:46, dcheng wrote:
> On 2016/05/13 at 21:30:07, alexmos wrote:
> > Now that this is only forwarding a message without any checking along the
way,
> the name sounds a bit out of date. WDYT about simplifying it to something like
> forwardMessageEvent, all the way to RenderFrameProxy?
> 
> I've renamed it to forwardPostMessage, since I think that's the only thing
it's
> used for. WDYT?

Perfect, LGTM.  Looks like this needs a rebase?

[dcheng, 2016-05-13 23:54:15]

dcheng@chromium.org changed reviewers:
+ creis@chromium.org, dpranke@chromium.org

[dcheng, 2016-05-13 23:54:16]

+dpranke for //components/test_runner OWNER
+creis for //content OWNER

[Dirk Pranke, 2016-05-14 00:24:13]

lgtm.

[Charlie Reis, 2016-05-16 20:32:53]

So nice!  content/ LGTM.

[dcheng, 2016-05-16 20:36:49]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-05-16 20:36:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
alexmos@chromium.org, dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1973133002/#ps120001
(title: "really fix rebase")

[commit-bot: I haz the power, 2016-05-16 20:37:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1973133002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1973133002/120001

[commit-bot: I haz the power, 2016-05-16 20:40:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 20:40:31]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[dcheng, 2016-05-16 21:14:42]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-05-16 21:14:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, creis@chromium.org, alexmos@chromium.org
Link to the patchset: https://codereview.chromium.org/1973133002/#ps140001
(title: "Rebase to use std::move instead of release().")

[commit-bot: I haz the power, 2016-05-16 21:15:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1973133002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1973133002/140001

[commit-bot: I haz the power, 2016-05-17 01:57:11]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-05-17 01:58:52]

Description was changed from

==========
✀ Remove postMessage plumbing for swappedout:// ✀

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
✀ Remove postMessage plumbing for swappedout:// ✀

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/b4a1a32e9393518ebd63c52f021eb5142954c9d6
Cr-Commit-Position: refs/heads/master@{#394016}
==========

[commit-bot: I haz the power, 2016-05-17 01:58:53]

Patchset 8 (id:??) landed as
https://crrev.com/b4a1a32e9393518ebd63c52f021eb5142954c9d6
Cr-Commit-Position: refs/heads/master@{#394016}