Add Easy Unlock options to chrome://settings behind a flag.

chromeos/chromeos_utils.cc

Index: chromeos/chromeos_utils.cc
diff --git a/chromeos/chromeos_utils.cc b/chromeos/chromeos_utils.cc
new file mode 100644
index 0000000000000000000000000000000000000000..16c815410b4778c8c532da8f1c285ecf4d7b6765
--- /dev/null
+++ b/chromeos/chromeos_utils.cc
@@ -0,0 +1,25 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromeos/chromeos_utils.h"
+
+#include "base/sys_info.h"
+
+namespace chromeos {
+
+namespace {
+  const char* kChromeboxBoards[]  = { "stumpy", "panther" };
+}
+
+std::string GetChromeDeviceType() {
+  std::string board = base::SysInfo::GetLsbReleaseBoard();
+  for (unsigned int i = 0; i < arraysize(kChromeboxBoards); ++i) {
+    std::string chromebox = kChromeboxBoards[i];
+    if (board.compare(0, chromebox.length(), chromebox) == 0)
+      return "Chromebox";
+  }
+  return "Chromebook";

[xiyuan, 2014/03/15 00:54:56]

These are UI facing strings. Shouldn't them be in a grd file? If using grd file,
/chromeos might not be a good place since it does not depend onl10n_util.

[Tim Song, 2014/03/17 19:12:07]

Hmm... there are a few other places that does a check like this (eg. Bluetooth,
Sync Session Name), and use the raw unlocalized string. As Panther is recently
released, each of these places need to be updated, so a common util function
would be helpful.

I also looked through some of the translated strings, and it doesn't look like
"Chromebook" or "Chromebox" are translated. There could be cases that these
names need localizing, so to be safe it makes sense to use a string resource.

However, the issue is that the components that currently does this check
(device/ and sync/) shouldn't really need to depend on ui/ either.

For now, I'll move this file to chrome/browser/chromeos, but we should probably
find a reusable solution for the other checks.

[xiyuan, 2014/03/17 20:04:50]

One possible solution is that GetChromeDeviceType in /chromeos component returns
an enum instead of a string and we have some util/helper function in /chrome to
translate the enum into a string.

This does not need to happen in this CL. I am okay with putting
GetChromeDeviceType in /c/b/chromeos for now.

+}
+
+}  // namespace chromeos