Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: tools/push-to-trunk/push_to_trunk.py

Issue 197313005: Revert "Maintain change log file directly on trunk branch in push-to-trunk." and related changes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/push-to-trunk/git_recipes.py ('k') | tools/push-to-trunk/test_scripts.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/push-to-trunk/push_to_trunk.py
diff --git a/tools/push-to-trunk/push_to_trunk.py b/tools/push-to-trunk/push_to_trunk.py
index 19a0d1d7d26d3f9bfe7401c7bf205922490c39bb..0ebfb9c295c77df304390feccc8355aa77c697bf 100755
--- a/tools/push-to-trunk/push_to_trunk.py
+++ b/tools/push-to-trunk/push_to_trunk.py
@@ -267,12 +267,8 @@ class SquashCommits(Step):
def RunStep(self):
# Instead of relying on "git rebase -i", we'll just create a diff, because
- # that's easier to automate. Exclude the ChangeLog file. It is not
- # maintained on bleeding edge. Changes will be added in a separate step
- # below.
- TextToFile(self.GitDiff("svn/trunk",
- self["prepare_commit_hash"],
- exclude=[self.Config(CHANGELOG_FILE)]),
+ # that's easier to automate.
+ TextToFile(self.GitDiff("svn/trunk", self["prepare_commit_hash"]),
self.Config(PATCH_FILE))
# Convert the ChangeLog entry to commit message format.
@@ -315,16 +311,6 @@ class ApplyChanges(Step):
Command("rm", "-f %s*" % self.Config(PATCH_FILE))
-class AddChangeLog(Step):
- MESSAGE = "Add ChangeLog changes to trunk branch."
-
- def RunStep(self):
- changelog_entry = FileToText(self.Config(NEW_CHANGELOG_FILE))
- old_change_log = FileToText(self.Config(CHANGELOG_FILE))
- new_change_log = "%s\n\n\n%s" % (changelog_entry, old_change_log)
- TextToFile(new_change_log, self.Config(CHANGELOG_FILE))
- os.remove(self.Config(NEW_CHANGELOG_FILE))
-
class SetVersion(Step):
MESSAGE = "Set correct version for trunk."
@@ -543,7 +529,6 @@ class PushToTrunk(ScriptsBase):
SquashCommits,
NewBranch,
ApplyChanges,
- AddChangeLog,
SetVersion,
CommitTrunk,
SanityCheck,
« no previous file with comments | « tools/push-to-trunk/git_recipes.py ('k') | tools/push-to-trunk/test_scripts.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698