Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 197313003: Fix TextAutosizer recalculate multipliers on rotate. (Closed)

Created:
6 years, 9 months ago by timvolodine
Modified:
6 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix TextAutosizer recalculate multipliers on rotate. Fix the for loop to actually reset the multipliers in all frames. Currently only main frame is reset inside the for-loop multiple times. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169678

Patch Set 1 #

Patch Set 2 : added test #

Patch Set 3 : fixed some layout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -33 lines) Patch
M Source/core/frame/FrameView.cpp View 1 1 chunk +4 lines, -9 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 4 chunks +59 lines, -24 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
timvolodine
6 years, 9 months ago (2014-03-13 12:09:45 UTC) #1
pdr.
On 2014/03/13 12:09:45, timvolodine wrote: This looks good to me. Is it possible to test ...
6 years, 9 months ago (2014-03-13 19:11:35 UTC) #2
timvolodine
On 2014/03/13 19:11:35, pdr wrote: > On 2014/03/13 12:09:45, timvolodine wrote: > > This looks ...
6 years, 9 months ago (2014-03-14 18:10:18 UTC) #3
pdr.
On 2014/03/14 18:10:18, timvolodine wrote: > On 2014/03/13 19:11:35, pdr wrote: > > On 2014/03/13 ...
6 years, 9 months ago (2014-03-14 18:11:13 UTC) #4
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-14 18:11:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/197313003/40001
6 years, 9 months ago (2014-03-14 18:11:29 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-14 18:18:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-14 18:18:02 UTC) #8
timvolodine
+ jochen@ for WebFrameTest.cpp.
6 years, 9 months ago (2014-03-14 18:33:21 UTC) #9
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-20 10:12:14 UTC) #10
timvolodine
The CQ bit was checked by timvolodine@chromium.org
6 years, 9 months ago (2014-03-20 19:04:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/197313003/40001
6 years, 9 months ago (2014-03-20 19:04:24 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 19:18:17 UTC) #13
Message was sent while issue was closed.
Change committed as 169678

Powered by Google App Engine
This is Rietveld 408576698