Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 197313002: Refactoring: Use explicit mock expectations for testing push and merge scripts. (Closed)

Created:
6 years, 9 months ago by Michael Achenbach
Modified:
6 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Visibility:
Public.

Description

Refactoring: Use explicit mock expectations for testing push and merge scripts. - Up to now, mock expectations were simple lists of arguments + return value - These expectations are now modeled explicitly including the name of the mock (e.g. git or readline) - The optional test callback function is now explicitly named - This will allow merging all mock expectation types (e.g. git and readline) into a single list per test case (follow up CL) TEST=tools/push-to-trunk/script_test.py R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -222 lines) Patch
M tools/push-to-trunk/test_scripts.py View 15 chunks +247 lines, -222 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
6 years, 9 months ago (2014-03-12 13:28:33 UTC) #1
Jarin
lgtm
6 years, 9 months ago (2014-03-12 14:34:30 UTC) #2
Michael Achenbach
6 years, 9 months ago (2014-03-12 14:39:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19853 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698