Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1973113002: Replaced glibc version of elf.h with musl version of elf.h. (Closed)

Created:
4 years, 7 months ago by dmac
Modified:
4 years, 7 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replaced glibc version of elf.h with musl version of elf.h. Updated dump_syms xcode project and ran tests. BUG= R=vapier@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/a84d4fc42639184d81ce06afea7041c79cf42d2e

Patch Set 1 #

Patch Set 2 : Added comment to change in elf_reader #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3032 lines, -4477 lines) Patch
M src/common/dwarf/elf_reader.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
D src/common/mac/include/features.h View 1 chunk +0 lines, -16 lines 0 comments Download
D src/third_party/glibc/COPYING View 1 chunk +0 lines, -339 lines 0 comments Download
D src/third_party/glibc/LICENSES View 1 chunk +0 lines, -469 lines 0 comments Download
D src/third_party/glibc/README View 1 chunk +0 lines, -76 lines 0 comments Download
D src/third_party/glibc/README.breakpad View 1 chunk +0 lines, -3 lines 0 comments Download
D src/third_party/glibc/elf/elf.h View 1 chunk +0 lines, -3572 lines 0 comments Download
A src/third_party/musl/COPYRIGHT View 1 chunk +163 lines, -0 lines 0 comments Download
A src/third_party/musl/README View 1 chunk +23 lines, -0 lines 0 comments Download
A src/third_party/musl/README.breakpad View 1 chunk +3 lines, -0 lines 0 comments Download
A src/third_party/musl/VERSION View 1 chunk +1 line, -0 lines 0 comments Download
A src/third_party/musl/include/elf.h View 1 chunk +2827 lines, -0 lines 0 comments Download
M src/tools/mac/dump_syms/dump_syms.xcodeproj/project.pbxproj View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dmaclach
PTAL
4 years, 7 months ago (2016-05-12 21:09:17 UTC) #2
vapier
lgtm
4 years, 7 months ago (2016-05-12 21:15:02 UTC) #3
dmac
Committed patchset #2 (id:20001) manually as a84d4fc42639184d81ce06afea7041c79cf42d2e (presubmit successful).
4 years, 7 months ago (2016-05-12 21:23:04 UTC) #5
Mark Mentovai
TM
4 years, 7 months ago (2016-05-12 23:38:23 UTC) #6
Mark Mentovai
4 years, 7 months ago (2016-05-12 23:38:39 UTC) #7
Message was sent while issue was closed.
I’m faster than Rietveld, so let’s try that again. LGTM.

Powered by Google App Engine
This is Rietveld 408576698