third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp - Issue 1973083002: Use element id's for animations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

Issue 1973083002: Use element id's for animations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: respond to reviewer feedback. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

index ef7a5d0f7b7b061d3385d9ac59b56a34564fd148..b2b70212893433209f90e7ff1a557b010bb6be03 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

@@ -335,7 +335,7 @@ void ScrollAnimator::updateCompositorAnimations()

}

if (m_runState == RunState::WaitingToSendToCompositor) {

- if (!m_compositorAnimationAttachedToLayerId)

+ if (!m_compositorAnimationAttachedToElementId)

reattachCompositorPlayerIfNeeded(getScrollableArea()->compositorAnimationTimeline());

if (!m_animationCurve) {