Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4034)

Unified Diff: cc/trees/property_tree.cc

Issue 1973083002: Use element id's for animations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: respond to reviewer feedback. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/property_tree.cc
diff --git a/cc/trees/property_tree.cc b/cc/trees/property_tree.cc
index 894b2d5da469a38121fc404424b943c810b494e4..89b8cea7b73672e2e48c315628d41d4c8a22a2e6 100644
--- a/cc/trees/property_tree.cc
+++ b/cc/trees/property_tree.cc
@@ -608,7 +608,6 @@ ScrollNodeData::ScrollNodeData()
should_flatten(false),
user_scrollable_horizontal(false),
user_scrollable_vertical(false),
- element_id(0),
transform_id(0),
num_drawn_descendants(0) {}
@@ -653,7 +652,7 @@ void ScrollNodeData::ToProtobuf(proto::TreeNode* proto) const {
data->set_should_flatten(should_flatten);
data->set_user_scrollable_horizontal(user_scrollable_horizontal);
data->set_user_scrollable_vertical(user_scrollable_vertical);
- data->set_element_id(element_id);
+ element_id.ToProtobuf(data->mutable_element_id());
data->set_transform_id(transform_id);
}
@@ -676,7 +675,7 @@ void ScrollNodeData::FromProtobuf(const proto::TreeNode& proto) {
should_flatten = data.should_flatten();
user_scrollable_horizontal = data.user_scrollable_horizontal();
user_scrollable_vertical = data.user_scrollable_vertical();
- element_id = data.element_id();
+ element_id.FromProtobuf(data.element_id());
transform_id = data.transform_id();
}
@@ -690,7 +689,8 @@ void ScrollNodeData::AsValueInto(base::trace_event::TracedValue* value) const {
value->SetBoolean("should_flatten", should_flatten);
value->SetBoolean("user_scrollable_horizontal", user_scrollable_horizontal);
value->SetBoolean("user_scrollable_vertical", user_scrollable_vertical);
- value->SetInteger("element_id", element_id);
+
+ element_id.AddToTracedValue(value);
value->SetInteger("transform_id", transform_id);
}

Powered by Google App Engine
This is Rietveld 408576698