Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/proto/property_tree.proto

Issue 1973083002: Use element id's for animations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: get element id's from scroll node data directly. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/layers/layer_impl.cc ('K') | « cc/proto/element_id.proto ('k') | cc/test/animation_test_common.h » ('j') | cc/trees/layer_tree_host_common_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/proto/property_tree.proto
diff --git a/cc/proto/property_tree.proto b/cc/proto/property_tree.proto
index 12dd474ffaf87674d5d42b2232f0e69922fa8a1d..35d0c29c4143f0662eda8bd080015cf000f25dae 100644
--- a/cc/proto/property_tree.proto
+++ b/cc/proto/property_tree.proto
@@ -4,6 +4,7 @@
syntax = "proto2";
+import "element_id.proto";
import "rectf.proto";
import "scroll_offset.proto";
import "size.proto";
@@ -106,7 +107,7 @@ message EffectNodeData {
}
// Proto for struct ScrollNodeData
-// NEXT ID: 15
+// NEXT ID: 16
message ScrollNodeData {
optional bool scrollable = 1;
optional int32 main_thread_scrolling_reasons = 2;
@@ -120,7 +121,7 @@ message ScrollNodeData {
optional bool should_flatten = 10;
optional bool user_scrollable_horizontal = 13;
optional bool user_scrollable_vertical = 14;
- optional int64 element_id = 12;
+ optional ElementId element_id = 15;
optional int64 transform_id = 11;
}
« cc/layers/layer_impl.cc ('K') | « cc/proto/element_id.proto ('k') | cc/test/animation_test_common.h » ('j') | cc/trees/layer_tree_host_common_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698