Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1449)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 1973083002: Use element id's for animations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address reviewer feedback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@gmail.com> 9 * Christian Biesinger <cbiesinger@gmail.com>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 27 matching lines...) Expand all
38 * deletingthe provisions above and replace them with the notice and 38 * deletingthe provisions above and replace them with the notice and
39 * other provisions required by the MPL or the GPL, as the case may be. 39 * other provisions required by the MPL or the GPL, as the case may be.
40 * If you do not delete the provisions above, a recipient may use your 40 * If you do not delete the provisions above, a recipient may use your
41 * version of this file under any of the LGPL, the MPL or the GPL. 41 * version of this file under any of the LGPL, the MPL or the GPL.
42 */ 42 */
43 43
44 #include "core/paint/PaintLayerScrollableArea.h" 44 #include "core/paint/PaintLayerScrollableArea.h"
45 45
46 #include "core/css/PseudoStyleRequest.h" 46 #include "core/css/PseudoStyleRequest.h"
47 #include "core/dom/AXObjectCache.h" 47 #include "core/dom/AXObjectCache.h"
48 #include "core/dom/DOMNodeIds.h"
48 #include "core/dom/Node.h" 49 #include "core/dom/Node.h"
49 #include "core/dom/shadow/ShadowRoot.h" 50 #include "core/dom/shadow/ShadowRoot.h"
50 #include "core/editing/FrameSelection.h" 51 #include "core/editing/FrameSelection.h"
51 #include "core/frame/FrameHost.h" 52 #include "core/frame/FrameHost.h"
52 #include "core/frame/FrameView.h" 53 #include "core/frame/FrameView.h"
53 #include "core/frame/LocalFrame.h" 54 #include "core/frame/LocalFrame.h"
54 #include "core/frame/Settings.h" 55 #include "core/frame/Settings.h"
55 #include "core/html/HTMLFrameOwnerElement.h" 56 #include "core/html/HTMLFrameOwnerElement.h"
56 #include "core/input/EventHandler.h" 57 #include "core/input/EventHandler.h"
57 #include "core/layout/LayoutFlexibleBox.h" 58 #include "core/layout/LayoutFlexibleBox.h"
(...skipping 1573 matching lines...) Expand 10 before | Expand all | Expand 10 after
1631 m_scrollableArea->m_rebuildVerticalScrollbarLayer = true; 1632 m_scrollableArea->m_rebuildVerticalScrollbarLayer = true;
1632 1633
1633 if (!scrollbar->isCustomScrollbar()) 1634 if (!scrollbar->isCustomScrollbar())
1634 m_scrollableArea->willRemoveScrollbar(*scrollbar, orientation); 1635 m_scrollableArea->willRemoveScrollbar(*scrollbar, orientation);
1635 1636
1636 toFrameView(scrollbar->parent())->removeChild(scrollbar.get()); 1637 toFrameView(scrollbar->parent())->removeChild(scrollbar.get());
1637 scrollbar->disconnectFromScrollableArea(); 1638 scrollbar->disconnectFromScrollableArea();
1638 scrollbar = nullptr; 1639 scrollbar = nullptr;
1639 } 1640 }
1640 1641
1642 uint64_t PaintLayerScrollableArea::id() const
1643 {
1644 return DOMNodeIds::idForNode(box().node());
1645 }
1646
1641 DEFINE_TRACE(PaintLayerScrollableArea::ScrollbarManager) 1647 DEFINE_TRACE(PaintLayerScrollableArea::ScrollbarManager)
1642 { 1648 {
1643 visitor->trace(m_scrollableArea); 1649 visitor->trace(m_scrollableArea);
1644 visitor->trace(m_hBar); 1650 visitor->trace(m_hBar);
1645 visitor->trace(m_vBar); 1651 visitor->trace(m_vBar);
1646 } 1652 }
1647 1653
1648 int PaintLayerScrollableArea::PreventRelayoutScope::s_count = 0; 1654 int PaintLayerScrollableArea::PreventRelayoutScope::s_count = 0;
1649 SubtreeLayoutScope* PaintLayerScrollableArea::PreventRelayoutScope::s_layoutScop e = nullptr; 1655 SubtreeLayoutScope* PaintLayerScrollableArea::PreventRelayoutScope::s_layoutScop e = nullptr;
1650 bool PaintLayerScrollableArea::PreventRelayoutScope::s_relayoutNeeded = false; 1656 bool PaintLayerScrollableArea::PreventRelayoutScope::s_relayoutNeeded = false;
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
1718 1724
1719 void PaintLayerScrollableArea::DelayScrollPositionClampScope::clampScrollableAre as() 1725 void PaintLayerScrollableArea::DelayScrollPositionClampScope::clampScrollableAre as()
1720 { 1726 {
1721 for (auto& scrollableArea : *s_needsClamp) 1727 for (auto& scrollableArea : *s_needsClamp)
1722 scrollableArea->clampScrollPositionsAfterLayout(); 1728 scrollableArea->clampScrollPositionsAfterLayout();
1723 delete s_needsClamp; 1729 delete s_needsClamp;
1724 s_needsClamp = nullptr; 1730 s_needsClamp = nullptr;
1725 } 1731 }
1726 1732
1727 } // namespace blink 1733 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698