third_party/WebKit/Source/platform/graphics/CompositorElementId.h - Issue 1973083002: Use element id's for animations

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/graphics/CompositorElementId.h

Issue 1973083002: Use element id's for animations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated CompositorMutableStateTest. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CompositorElementId_h

	6 #define CompositorElementId_h

	7

	8 #include "cc/animation/element_id.h"

	9 #include "platform/PlatformExport.h"

	10

	11 namespace blink {

	12

	13 enum class CompositorSubElementId {

	14 Primary = 1,
	jbroman 2016/06/06 14:23:20 nit: Any reason to assign these explicit values, i nit: Any reason to assign these explicit values, instead of letting the compiler assign them? Letting the compiler do it makes the diff smaller if one is ever removed. Ian Vollick 2016/06/06 16:31:29 No reason. Removed. Show quoted text On 2016/06/06 14:23:20, jbroman wrote: > nit: Any reason to assign these explicit values, instead of letting the compiler > assign them? Letting the compiler do it makes the diff smaller if one is ever > removed. No reason. Removed.
	15 Scroll = 2,

	16 LinkHighlight = 3

	17 };

	18

	19 using CompositorElementId = cc::ElementId;

	20

	21 CompositorElementId PLATFORM_EXPORT createCompositorElementId(int domNodeId, Com positorSubElementId);

	22

	23 } // namespace blink

	24

	25 #endif // CompositorElementId_h

OLD	NEW