third_party/WebKit/Source/platform/graphics/CompositorElementId.h - Issue 1973083002: Use element id's for animations

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/graphics/CompositorElementId.h

Issue 1973083002: Use element id's for animations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: get element id's from scroll node data directly. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CompositorElementId_h

	6 #define CompositorElementId_h

	7

	8 #include "cc/animation/element_id.h"

	9

	10 namespace blink {

	11

	12 static const int kScrollSubElement = 1;

	13 static const int kViewportScrollSubElement = 2;

	14 static const int kLinkHighlightSubElement = 3;
	ajuma 2016/06/01 23:53:42 I think these should go into a sub-namespace (e.g. I think these should go into a sub-namespace (e.g. CompositorElementSubId). Ian Vollick 2016/06/02 19:03:11 Done. Show quoted text On 2016/06/01 23:53:42, ajuma wrote: > I think these should go into a sub-namespace (e.g. CompositorElementSubId). Done.
	15

	16 using CompositorElementId = cc::ElementId;

	17

	18 } // namespace blink

	19

	20 #endif // CompositorElementId_h

OLD	NEW