WebGL expectations: add unittest checking pages exist.

WebGL expectations: check the path for Flaky expectations too

BUG=607393
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/c88d76425b8d15a6f569c04557ad292312f67517
Cr-Commit-Position: refs/heads/master@{#393551}

[Corentin Wallez, 2016-05-12 17:27:00]

Description was changed from

==========
WebGL expectations: add unittest checking pages exist.

This will prevent typos in the expectations.

BUG=607393
==========

to

==========
WebGL expectations: add unittest checking pages exist.

This will prevent typos in the expectations.

BUG=607393
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2016-05-12 17:27:17]

cwallez@chromium.org changed reviewers:
+ jmadill@chromium.org, kbr@chromium.org, zmo@chromium.org

[Corentin Wallez, 2016-05-12 17:27:18]

PTAL

[Zhenyao Mo, 2016-05-12 17:35:06]

On 2016/05/12 17:27:18, Corentin Wallez wrote:
> PTAL

lgtm

[Corentin Wallez, 2016-05-12 17:46:51]

PTAL again, I found the actual root cause. Sorry for the spam

[Jamie Madill, 2016-05-12 17:48:58]

LGTM as well, thanks for fixing.

[Zhenyao Mo, 2016-05-12 17:52:04]

Will this catch wrong entries at patch upload time?

If not, then your previous test is still valuable.

[Corentin Wallez, 2016-05-12 17:56:12]

On 2016/05/12 at 17:52:04, zmo wrote:
> Will this catch wrong entries at patch upload time?
> 
> If not, then your previous test is still valuable.

Yes it will be caught as soon as an expectation object is created, which is done
in the "conflicts unittest"

[Zhenyao Mo, 2016-05-12 19:13:49]

On 2016/05/12 17:56:12, Corentin Wallez wrote:
> On 2016/05/12 at 17:52:04, zmo wrote:
> > Will this catch wrong entries at patch upload time?
> > 
> > If not, then your previous test is still valuable.
> 
> Yes it will be caught as soon as an expectation object is created, which is
done
> in the "conflicts unittest"

Good.  Thanks.

lgtm again.

[Ken Russell (switch to Gerrit), 2016-05-12 20:50:37]

Very nice. Thanks for fixing this. LGTM

[Ken Russell (switch to Gerrit), 2016-05-12 20:51:01]

btw please consider updating the CL description before landing. thanks.

[Corentin Wallez, 2016-05-13 14:44:12]

Description was changed from

==========
WebGL expectations: add unittest checking pages exist.

This will prevent typos in the expectations.

BUG=607393
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
WebGL expectations: check the path for Flaky expectations too

BUG=607393
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2016-05-13 14:44:48]

On 2016/05/12 at 20:51:01, kbr wrote:
> btw please consider updating the CL description before landing. thanks.

Thanks for the rereview. Update the description (reitveld doesn't pick up update
commit messages?)

[Corentin Wallez, 2016-05-13 14:44:52]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2016-05-13 14:45:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1973053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1973053002/20001

[commit-bot: I haz the power, 2016-05-13 16:51:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-13 16:54:07]

Description was changed from

==========
WebGL expectations: check the path for Flaky expectations too

BUG=607393
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
WebGL expectations: check the path for Flaky expectations too

BUG=607393
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/c88d76425b8d15a6f569c04557ad292312f67517
Cr-Commit-Position: refs/heads/master@{#393551}
==========

[commit-bot: I haz the power, 2016-05-13 16:54:08]

Patchset 2 (id:??) landed as
https://crrev.com/c88d76425b8d15a6f569c04557ad292312f67517
Cr-Commit-Position: refs/heads/master@{#393551}

[Ken Russell (switch to Gerrit), 2016-05-13 17:27:34]

On 2016/05/13 14:44:48, Corentin Wallez wrote:
> On 2016/05/12 at 20:51:01, kbr wrote:
> > btw please consider updating the CL description before landing. thanks.
> 
> Thanks for the rereview. Update the description (reitveld doesn't pick up
update
> commit messages?)

Nope, it doesn't. Another reason to switch to Gerrit...