Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1973043002: Fix typo in SkOSWindow_AndroidNative. (Closed)

Created:
4 years, 7 months ago by bungeman-skia
Modified:
4 years, 7 months ago
Reviewers:
djsollen, liyuqian
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix typo in SkOSWindow_AndroidNative. This allows the 'most' target to be built on Android. Committed: https://skia.googlesource.com/skia/+/b11cf50b4a07be00b80816c67f738588357330bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M platform_tools/android/apps/visualbench/src/main/jni/SkOSWindow_AndroidNative.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
bungeman-skia
4 years, 7 months ago (2016-05-12 17:27:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973043002/1
4 years, 7 months ago (2016-05-12 17:28:04 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 7 months ago (2016-05-12 17:28:05 UTC) #7
bungeman-skia
4 years, 7 months ago (2016-05-12 17:34:33 UTC) #9
liyuqian
On 2016/05/12 17:34:33, bungeman-skia wrote: lgtm. I just caught it in my local build too ...
4 years, 7 months ago (2016-05-12 17:39:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b11cf50b4a07be00b80816c67f738588357330bd
4 years, 7 months ago (2016-05-12 17:49:02 UTC) #12
djsollen
4 years, 7 months ago (2016-05-12 17:49:05 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698